feat(ast): add `ThisExpression` to `TSTypeName` by Boshen · Pull Request #12156 · oxc-project/oxc

Boshen · 2025-07-09T09:42:38Z

part of #12042

Aligned with estree: https://github.com/typescript-eslint/typescript-eslint/blob/5c5e3d5c3853ab613e06be0d77a40e970017b3fc/packages/ast-spec/src/unions/EntityName.ts#L5

Boshen · 2025-07-09T09:42:57Z

feat(ast): add ThisExpression to TSTypeName #12156 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-07-09T09:47:33Z

CodSpeed Instrumentation Performance Report

Merging #12156 will not alter performance

_{Comparing 07-09-feat_ast_add_thisexpression_to_tstypename_ (9b14fbc) with main (d0f8b88)}

Summary

✅ 34 untouched benchmarks

crates/oxc_transformer/src/decorator/legacy/metadata.rs

tasks/coverage/snapshots/semantic_babel.snap

crates/oxc_ast/src/ast/ts.rs

Dunqing · 2025-07-09T14:10:30Z

It is weird that TSTypeName has a ThisExpression rather than TSThisType, though I know it is to align with typescript-estree.

overlookmotel · 2025-07-09T16:32:43Z

It is weird that TSTypeName has a ThisExpression rather than TSThisType, though I know it is to align with typescript-estree.

If we think TS-ESLint has this wrong, we can make it TSThisType in Rust AST, and convert to ThisExpression in ESTree conversion, so JS-side AST still aligns with TS-ESLint.

I don't really understand why TSThisType exists at all (rather than just using ThisExpression everywhere), given that we don't have a special TSIdentifierReference for identifiers used in TS types.

Boshen · 2025-07-13T01:35:54Z

Merge activity

Jul 13, 1:35 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jul 13, 1:43 AM UTC: Boshen added this pull request to the Graphite merge queue.
Jul 13, 1:52 AM UTC: Merged by the Graphite merge queue.

part of #12042 Aligned with estree: https://github.com/typescript-eslint/typescript-eslint/blob/5c5e3d5c3853ab613e06be0d77a40e970017b3fc/packages/ast-spec/src/unions/EntityName.ts#L5

## [1.7.0] - 2025-07-16 ### 🚀 Features - 5e428a4 linter/eslint-plugin-next: No-html-link-for-pages rule addition (#12194) (Gabriel Díaz Aguilera) - 9b14fbc ast: Add `ThisExpression` to `TSTypeName` (#12156) (Boshen) - c551b8f linter: Report diagnostics from custom plugins (#12219) (camc314) - d387729 linter: JS custom rules config (#12160) (camc314) - 152e59d napi/oxlint: Read source text into start of allocator (#12122) (overlookmotel) - bde1ef1 linter: Load custom JS plugins (#11980) (camc314) - d4ebd14 linter: Add `oxlint2`/`disable_oxlint2` feature flags (#12130) (camc314) - a4dae73 linter: Introduce `LintPlugins` to store builtin + custom plugins (#12117) (camc314) ### 🐛 Bug Fixes - 3f9a1f0 linter/no-unused-private-class-members: Fix false positive with nullish coalescing assignments (#12317) (camc314) - 47fad0e linter/no-empty-file: False positive with empty file with triple slash directive (#12293) (camc314) - 633ba30 linter: False positive with unknown plugins when unmatched eslint rule (#12285) (camc314) - 9720774 linter: Report implicit config parse errors (#12260) (Simon Buchan) - 1920c6b language_server: Respect the root `.oxlintrc.json` file for `ignorePatterns` (#12171) (Sysix) - 98708eb linter: Fix inconsistent behavior in `no-duplicate-imports` rule (#12192) (yefan) - 853d2bc linter, language_server: Correctly identify usage of `import` plugin (#12157) (overlookmotel) ### 🚜 Refactor - ee761de ast: Remove `AstKind` for `AssignmentTarget` (#12252) (Tyler Earls) - c68b607 ast: Rename `TemplateLiteral::quasi` to `TemplateLiteral::single_quasi` (#12266) (Dunqing) - 32c32af ast: Check whether there is a single `quasi` in `TemplateLiteral::quasi` (#12265) (Dunqing) - 8f6a1da linter/js-plugins: Use `u32` for IDs (#12243) (overlookmotel) - 36cd364 linter/js-plugins: Clean up code (#12242) (overlookmotel) - 8c02ebd linter/js-plugins: Rename `specifiers` to `paths` (#12241) (overlookmotel) - 3adaf98 linter: Simplify getting nodes count (#12239) (overlookmotel) - 6e54645 language_server: Store `LintService` instead of `Linter` (#12016) (Sysix) - 113cf8c linter: Move `LintServiceOptions.paths` to `LintService.with_paths` (#12015) (Sysix) - acfac68 oxlint: Adjust ignore patterns by counting bytes instead of chars (#12209) (Sysix) - 729b82b linter: Rename `plugin_name` to `plugin_specifier` (#12148) (overlookmotel) - 532b816 linter: Use `to_string` instead of `into` (#12147) (overlookmotel) - 89f2a69 linter: TODO comment (#12146) (overlookmotel) - f90d3e1 linter: Feature gate `load_external_plugin` by both `oxlint2` and `disable_oxlint2` features (#12141) (overlookmotel) - 12e4ec7 linter: Make `tokio` dependency optional (#12140) (overlookmotel) - 1d2eaca oxlint2: Introduce `force_test_reporter` feature for consistent graphical outputs (#12133) (camc314) - 8814c53 ast: Remove `AstKind` for `PropertyKey` (#12108) (camchenry) - 228cff5 semantic,linter: Assert that Program is always the first node (#12123) (Ulrich Stark) - e8e2a25 ast: Remove `AstKind` for `AssignmentTargetPattern` (#12105) (camchenry) - f7c675d linter: Rename `LintPlugins` to `BuiltinLintPlugins` (#12116) (camc314) - a9e5ec0 linter: Access plugins through config instead of storing directly (#12115) (camc314) - 9736a7f linter: Simplify `unicorn/require-post-message-target-origin` (#12110) (shulaoda) ### 📚 Documentation - 2e3db46 linter: Add missing backtick preventing website from building (#12113) (camc314) ### ⚡ Performance - d0f8b88 linter/js-plugins: Do not copy `Vec` (#12248) (overlookmotel) - 4284d19 linter/js-plugins: Use hashmap `Entry` API + remove temp `Vec` (#12247) (overlookmotel) - c7889c3 semantic,linter: Simplify implementation and uses of ancestors iterators (#12164) (Ulrich Stark) - f99959c linter: Move work out of loop (#12145) (overlookmotel) - 514d40c linter: Do not create `Resolver` unless required (#12142) (overlookmotel) - 7103527 linter/no-constructor-return: Optimize loop (#12138) (overlookmotel) ### 🧪 Testing - d1194e8 oxlint: Ignore test on windows (#12262) (camc314) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

Boshen requested review from Dunqing, camc314 and overlookmotel as code owners July 9, 2025 09:42

github-actions bot added A-linter Area - Linter A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations A-formatter Area - Formatter C-enhancement Category - New feature or request labels Jul 9, 2025

Boshen force-pushed the 07-09-feat_ast_add_thisexpression_to_tstypename_ branch from 101caa4 to fd276eb Compare July 9, 2025 09:53

github-actions bot added the A-parser Area - Parser label Jul 9, 2025

Boshen commented Jul 9, 2025

View reviewed changes

crates/oxc_transformer/src/decorator/legacy/metadata.rs Show resolved Hide resolved

Boshen force-pushed the 07-09-feat_ast_add_thisexpression_to_tstypename_ branch from fd276eb to d2e57ce Compare July 9, 2025 09:58

Boshen commented Jul 9, 2025

View reviewed changes

tasks/coverage/snapshots/semantic_babel.snap Show resolved Hide resolved

overlookmotel reviewed Jul 9, 2025

View reviewed changes

crates/oxc_ast/src/ast/ts.rs Outdated Show resolved Hide resolved

Boshen mentioned this pull request Jul 11, 2025

invalid dts generation rolldown/tsdown#372

Closed

Boshen force-pushed the 07-09-feat_ast_add_thisexpression_to_tstypename_ branch 3 times, most recently from 19f3298 to b7f46fb Compare July 13, 2025 01:35

Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 13, 2025

feat(ast): add ThisExpression to TSTypeName (#12156)

9b14fbc

part of #12042 Aligned with estree: https://github.com/typescript-eslint/typescript-eslint/blob/5c5e3d5c3853ab613e06be0d77a40e970017b3fc/packages/ast-spec/src/unions/EntityName.ts#L5

graphite-app bot force-pushed the 07-09-feat_ast_add_thisexpression_to_tstypename_ branch from b7f46fb to 9b14fbc Compare July 13, 2025 01:44

graphite-app bot merged commit 9b14fbc into main Jul 13, 2025
26 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 13, 2025

graphite-app bot deleted the 07-09-feat_ast_add_thisexpression_to_tstypename_ branch July 13, 2025 01:52

This was referenced Jul 16, 2025

release(crates): v0.77.1 #12319

Merged

release(oxlint): v1.7.0 #12326

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(ast): add `ThisExpression` to `TSTypeName`#12156

feat(ast): add `ThisExpression` to `TSTypeName`#12156
graphite-app[bot] merged 1 commit intomainfrom
07-09-feat_ast_add_thisexpression_to_tstypename_

Boshen commented Jul 9, 2025 •

edited

Loading

Uh oh!

Boshen commented Jul 9, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jul 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dunqing commented Jul 9, 2025

Uh oh!

overlookmotel commented Jul 9, 2025

Uh oh!

Boshen commented Jul 13, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Boshen commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Boshen commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #12156 will not alter performance

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dunqing commented Jul 9, 2025

Uh oh!

overlookmotel commented Jul 9, 2025

Uh oh!

Boshen commented Jul 13, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Boshen commented Jul 9, 2025 •

edited

Loading

Boshen commented Jul 9, 2025 •

edited

Loading

codspeed-hq bot commented Jul 9, 2025 •

edited

Loading

Boshen commented Jul 13, 2025 •

edited by graphite-app bot

Loading