Skip to content

refactor(semantic): remove redundant code handling reference flags#12043

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-03-refactor_semantic_remove_redundant_code_handling_reference_flags
Jul 3, 2025
Merged

refactor(semantic): remove redundant code handling reference flags#12043
graphite-app[bot] merged 1 commit intomainfrom
07-03-refactor_semantic_remove_redundant_code_handling_reference_flags

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 3, 2025

This PR is a follow-up to #11990. After AstKind::TSTypeName has been removed, a lot of prior handling of the kind can be removed. The semantic snapshot changes are expected, caused by #12042.

@github-actions github-actions bot added the A-semantic Area - Semantic label Jul 3, 2025
Copy link
Member Author

Dunqing commented Jul 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jul 3, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 3, 2025

CodSpeed Instrumentation Performance Report

Merging #12043 will not alter performance

Comparing 07-03-refactor_semantic_remove_redundant_code_handling_reference_flags (07e14a4) with main (f1d4086)

Summary

✅ 38 untouched benchmarks

@Dunqing Dunqing force-pushed the 07-03-refactor_semantic_remove_redundant_code_handling_reference_flags branch from 72ceb86 to 03090f5 Compare July 3, 2025 03:08
@Dunqing Dunqing requested a review from camchenry July 3, 2025 03:16
Copy link
Member

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks like this might even be a +1-2% perf win too

Image

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jul 3, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 3, 2025

Merge activity

…12043)

This PR is a follow-up to #11990. After `AstKind::TSTypeName` has been removed, a lot of prior handling of the kind can be removed. The semantic snapshot changes are expected, caused by #12042.
@graphite-app graphite-app bot force-pushed the 07-03-refactor_semantic_remove_redundant_code_handling_reference_flags branch from 03090f5 to 07e14a4 Compare July 3, 2025 04:26
@graphite-app graphite-app bot merged commit 07e14a4 into main Jul 3, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 3, 2025
@graphite-app graphite-app bot deleted the 07-03-refactor_semantic_remove_redundant_code_handling_reference_flags branch July 3, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants