refactor(ast): remove AstKind for TSTypeName

[camchenry]

• part of Make AstKind consistent #11490

[camchenry]

• refactor(ast): remove AstKind for ModuleDeclaration #12022
• refactor(ast): remove AstKind for TSTypeName #11990 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #11990 will not alter performance

_{Comparing 06-30-refactor_ast_remove_astkind_for_tstypename_ (754c05a) with main (3982963)}

Summary

✅ 38 untouched benchmarks

[camchenry]

There's a small issue in conformance with semantic. I'm not exactly sure why yet, looks like it has something to do with handling reference flags with TSImportType maybe.

[Dunqing]

There's a small issue in conformance with semantic. I'm not exactly sure why yet, looks like it has something to do with handling reference flags with TSImportType maybe.

I just found out that the field qualifier of TSImportType is TSTypeName, so that there is an identifier reference. But this is wrong because TSImportType shouldn't have any reference.

oxc/crates/oxc_ast/src/ast/ts.rs

Lines 1353 to 1359 in fadbd93

	pub struct TSImportType<'a> {
	pub span: Span,
	pub argument: TSType<'a>,
	pub options: Option<Box<'a, ObjectExpression<'a>>>,
	pub qualifier: Option<TSTypeName<'a>>,
	pub type_arguments: Option<Box<'a, TSTypeParameterInstantiation<'a>>>,
	}

type A = import("./a").b.c
                       ^ This is an identifier reference now.

[Dunqing]

Looks good. Since AstKind::TSTypeName has been removed, the prior handling of AstKind::TSTypeName in the Semantic can be simplified a lot. I will create a PR to do that in the follow-up.

[camchenry]

Merge activity

• Jul 3, 2:28 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jul 3, 2:29 AM UTC: camchenry added this pull request to the Graphite merge queue.
• Jul 3, 2:37 AM UTC: Merged by the Graphite merge queue.