Skip to content

fix(ast/estree): add optional range field to Span in TS type defs #12014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jul 1, 2025
Merged

fix(ast/estree): add optional range field to Span in TS type defs #12014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crates/oxc_span/src/span.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,12 @@ pub const SPAN: Span = Span::new(0, 0);
#[generate_derive(ESTree)]
#[builder(skip)]
#[content_eq(skip)]
#[estree(no_type, flatten)]
#[estree(
no_type,
flatten,
no_ts_def,
add_ts_def = "interface Span { start: number; end: number; range?: [number, number]; }"
)]
pub struct Span {
/// The zero-based start offset of the span
pub start: u32,
Expand Down
1 change: 1 addition & 0 deletions npm/oxc-types/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1515,6 +1515,7 @@ export type UpdateOperator = '++' | '--';
export interface Span {
start: number;
end: number;
range?: [number, number];
}

export type ModuleKind = 'script' | 'module';
Expand Down
Loading