Skip to content

fix(ast/estree): add optional range field to Span in TS type defs#12014

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-01-fix_ast_estree_add_optional_range_field_to_span_in_ts_type_defs
Jul 1, 2025
Merged

fix(ast/estree): add optional range field to Span in TS type defs#12014
graphite-app[bot] merged 1 commit intomainfrom
07-01-fix_ast_estree_add_optional_range_field_to_span_in_ts_type_defs

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 1, 2025

Part of #10307.

Add optional range field to Span in TS type defs. All other types which have a span extend Span, so this adds range field to all AST types.

@github-actions github-actions bot added the C-bug Category - Bug label Jul 1, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 1, 2025 18:41
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 1, 2025
Copy link
Member Author

overlookmotel commented Jul 1, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 1, 2025

CodSpeed Instrumentation Performance Report

Merging #12014 will degrade performances by 8.09%

Comparing 07-01-fix_ast_estree_add_optional_range_field_to_span_in_ts_type_defs (d7076b3) with main (016634f)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 2.7 ms 3 ms -8.09%

…#12014)

Part of #10307.

Add optional `range` field to `Span` in TS type defs. All other types which have a span extend `Span`, so this adds `range` field to all AST types.
@graphite-app graphite-app bot force-pushed the 07-01-fix_ast_estree_add_optional_range_field_to_span_in_ts_type_defs branch from 1a9f88f to d7076b3 Compare July 1, 2025 18:49
@graphite-app graphite-app bot merged commit d7076b3 into main Jul 1, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 07-01-fix_ast_estree_add_optional_range_field_to_span_in_ts_type_defs branch July 1, 2025 18:58
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant