Skip to content

refactor(ast/estree): simplify adding range field#12005

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-01-refactor_ast_estree_simplify_adding_range_field
Jul 1, 2025
Merged

refactor(ast/estree): simplify adding range field#12005
graphite-app[bot] merged 1 commit intomainfrom
07-01-refactor_ast_estree_simplify_adding_range_field

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 1, 2025

Follow-on after #11890. Simplify adding range field to ESTree AST. Most changes are to serialize range as &[u32; 2] instead of &[&u32; 2].

Copy link
Member Author

overlookmotel commented Jul 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 1, 2025
@overlookmotel overlookmotel marked this pull request as ready for review July 1, 2025 14:28
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 1, 2025
Copy link
Member Author

overlookmotel commented Jul 1, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 1, 2025

CodSpeed Instrumentation Performance Report

Merging #12005 will not alter performance

Comparing 07-01-refactor_ast_estree_simplify_adding_range_field (dc04dbc) with main (b446a66)

Summary

✅ 38 untouched benchmarks

Follow-on after #11890. Simplify adding `range` field to ESTree AST. Most changes are to serialize `range` as `&[u32; 2]` instead of `&[&u32; 2]`.
@graphite-app graphite-app bot force-pushed the 07-01-refactor_ast_estree_simplify_adding_range_field branch from 52cd6c7 to dc04dbc Compare July 1, 2025 14:36
@graphite-app graphite-app bot merged commit dc04dbc into main Jul 1, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 1, 2025
@graphite-app graphite-app bot deleted the 07-01-refactor_ast_estree_simplify_adding_range_field branch July 1, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant