Skip to content

feat(ast): add range field to custom serializers#11890

Merged
overlookmotel merged 4 commits intooxc-project:mainfrom
bacarybruno:range-field-custom-serializers
Jul 1, 2025
Merged

feat(ast): add range field to custom serializers#11890
overlookmotel merged 4 commits intooxc-project:mainfrom
bacarybruno:range-field-custom-serializers

Conversation

@bacarybruno
Copy link
Contributor

To continue on this work #11728
Context: #10307 (comment)

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 25, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@bacarybruno bacarybruno changed the title feat: add range field on custom serializers feat: add range field to custom serializers Jun 25, 2025
@github-actions github-actions bot added the A-ast Area - AST label Jun 25, 2025
@bacarybruno bacarybruno changed the title feat: add range field to custom serializers feat(ast): add range field to custom serializers Jun 25, 2025
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Jun 25, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 25, 2025

CodSpeed Instrumentation Performance Report

Merging #11890 will improve performances by 15.17%

Comparing bacarybruno:range-field-custom-serializers (e87e8f0) with main (9f6784a)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.5 ms 3.1 ms +15.17%

@Boshen Boshen requested a review from overlookmotel June 25, 2025 09:40
@overlookmotel overlookmotel merged commit 79c93e3 into oxc-project:main Jul 1, 2025
23 checks passed
graphite-app bot pushed a commit that referenced this pull request Jul 1, 2025
Follow-on after #11890. Simplify adding `range` field to ESTree AST. Most changes are to serialize `range` as `&[u32; 2]` instead of `&[&u32; 2]`.
graphite-app bot pushed a commit that referenced this pull request Jul 1, 2025
Follow-on after #11890. Add missing `range` field to `TSModuleDeclaration`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants