Skip to content

fix(semantic): remove needless ts type param empty check#11899

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/06-25-fix_semantic_remove_needless_ts_type_param_empty_check
Jun 25, 2025
Merged

fix(semantic): remove needless ts type param empty check#11899
graphite-app[bot] merged 1 commit intomainfrom
c/06-25-fix_semantic_remove_needless_ts_type_param_empty_check

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jun 25, 2025

we already check this in the parser, we don't need to check in semantic as well

#[cold]
pub fn ts_empty_type_parameter_list(span: Span) -> OxcDiagnostic {
ts_error("1098", "Type parameter list cannot be empty.").with_label(span)
}

@github-actions github-actions bot added A-semantic Area - Semantic C-bug Category - Bug labels Jun 25, 2025
Copy link
Contributor Author

camc314 commented Jun 25, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review June 25, 2025 12:30
@camc314 camc314 requested a review from Dunqing as a code owner June 25, 2025 12:30
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 25, 2025

CodSpeed Instrumentation Performance Report

Merging #11899 will improve performances by 5.67%

Comparing c/06-25-fix_semantic_remove_needless_ts_type_param_empty_check (404cb14) with main (d25dc35)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.1 ms 2.9 ms +5.67%

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jun 25, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 25, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/06-25-fix_semantic_remove_needless_ts_type_param_empty_check branch from a3e789e to 404cb14 Compare June 25, 2025 12:42
@graphite-app graphite-app bot merged commit 404cb14 into main Jun 25, 2025
23 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 25, 2025
@graphite-app graphite-app bot deleted the c/06-25-fix_semantic_remove_needless_ts_type_param_empty_check branch June 25, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant