Skip to content

fix(parser): panic when parsing interface with missing implements#11898

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/06-25-fix_parser_panic_when_parsing_interface_with_missing_implements
Jun 25, 2025
Merged

fix(parser): panic when parsing interface with missing implements#11898
graphite-app[bot] merged 1 commit intomainfrom
c/06-25-fix_parser_panic_when_parsing_interface_with_missing_implements

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jun 25, 2025

No description provided.

@camc314 camc314 marked this pull request as ready for review June 25, 2025 12:26
@github-actions github-actions bot added the A-parser Area - Parser label Jun 25, 2025
Copy link
Contributor Author

camc314 commented Jun 25, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Jun 25, 2025
@camc314 camc314 changed the base branch from main to graphite-base/11898 June 25, 2025 12:31
@camc314 camc314 force-pushed the graphite-base/11898 branch from d25dc35 to a3e789e Compare June 25, 2025 12:31
@camc314 camc314 force-pushed the c/06-25-fix_parser_panic_when_parsing_interface_with_missing_implements branch from 9c6bd14 to 98c8944 Compare June 25, 2025 12:31
@camc314 camc314 changed the base branch from graphite-base/11898 to c/06-25-fix_semantic_remove_needless_ts_type_param_empty_check June 25, 2025 12:32
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 25, 2025

CodSpeed Instrumentation Performance Report

Merging #11898 will create unknown performance changes

Comparing c/06-25-fix_parser_panic_when_parsing_interface_with_missing_implements (6c9c580) with c/06-25-fix_semantic_remove_needless_ts_type_param_empty_check (404cb14)

Summary

🆕 38 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[RadixUIAdoptionSection.jsx] N/A 133.5 µs N/A
🆕 codegen[binder.ts] N/A 4.8 ms N/A
🆕 codegen[cal.com.tsx] N/A 39.1 ms N/A
🆕 codegen[react.development.js] N/A 2.2 ms N/A
🆕 formatter[RadixUIAdoptionSection.jsx] N/A 315.9 µs N/A
🆕 formatter[binder.ts] N/A 20.2 ms N/A
🆕 formatter[cal.com.tsx] N/A 157.7 ms N/A
🆕 formatter[react.development.js] N/A 9.9 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21 µs N/A
🆕 lexer[binder.ts] N/A 930 µs N/A
🆕 lexer[cal.com.tsx] N/A 5.8 ms N/A
🆕 lexer[react.development.js] N/A 384 µs N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.6 ms N/A
🆕 linter[binder.ts] N/A 149.9 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[react.development.js] N/A 54.9 ms N/A
🆕 mangler[RadixUIAdoptionSection.jsx] N/A 14.2 µs N/A
🆕 mangler[binder.ts] N/A 807.7 µs N/A
🆕 mangler[cal.com.tsx] N/A 3.1 ms N/A
🆕 mangler[react.development.js] N/A 284 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@camc314 camc314 force-pushed the c/06-25-fix_parser_panic_when_parsing_interface_with_missing_implements branch from 98c8944 to d1548e0 Compare June 25, 2025 12:33
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 25, 2025
Copy link
Member

Boshen commented Jun 25, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/06-25-fix_semantic_remove_needless_ts_type_param_empty_check branch from a3e789e to 404cb14 Compare June 25, 2025 12:42
@graphite-app graphite-app bot requested a review from Dunqing as a code owner June 25, 2025 12:42
@graphite-app graphite-app bot force-pushed the c/06-25-fix_parser_panic_when_parsing_interface_with_missing_implements branch from d1548e0 to 6c9c580 Compare June 25, 2025 12:43
Base automatically changed from c/06-25-fix_semantic_remove_needless_ts_type_param_empty_check to main June 25, 2025 12:49
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 25, 2025
@graphite-app graphite-app bot merged commit 6c9c580 into main Jun 25, 2025
26 checks passed
@graphite-app graphite-app bot deleted the c/06-25-fix_parser_panic_when_parsing_interface_with_missing_implements branch June 25, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants