Skip to content

refactor(parser): replace peek with lookahead in parsing delimited lists#11337

Closed
camchenry wants to merge 1 commit intomainfrom
05-27-refactor_parser_replace_peek_with_lookahead_in_parsing_delimited_lists
Closed

refactor(parser): replace peek with lookahead in parsing delimited lists#11337
camchenry wants to merge 1 commit intomainfrom
05-27-refactor_parser_replace_peek_with_lookahead_in_parsing_delimited_lists

Conversation

@camchenry
Copy link
Member

No description provided.

@github-actions github-actions bot added the A-parser Area - Parser label May 27, 2025
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label May 27, 2025
Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented May 27, 2025

CodSpeed Instrumentation Performance Report

Merging #11337 will degrade performances by 4.38%

Comparing 05-27-refactor_parser_replace_peek_with_lookahead_in_parsing_delimited_lists (77aac64) with main (99e6490)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[RadixUIAdoptionSection.jsx] 13.6 µs 14.2 µs -4.38%

@graphite-app graphite-app bot changed the base branch from 05-27-refactor_parser_remove_lexer_lookahead_in_module_parsing to graphite-base/11337 May 28, 2025 01:55
@graphite-app graphite-app bot force-pushed the graphite-base/11337 branch from f85a6a4 to 99e6490 Compare May 28, 2025 02:01
@graphite-app graphite-app bot force-pushed the 05-27-refactor_parser_replace_peek_with_lookahead_in_parsing_delimited_lists branch from c19bd40 to 581c49f Compare May 28, 2025 02:01
@graphite-app graphite-app bot changed the base branch from graphite-base/11337 to main May 28, 2025 02:02
@graphite-app graphite-app bot force-pushed the 05-27-refactor_parser_replace_peek_with_lookahead_in_parsing_delimited_lists branch from 581c49f to 77aac64 Compare May 28, 2025 02:02
@overlookmotel
Copy link
Member

#11343 has dealt with this in another way.

@camchenry camchenry closed this May 28, 2025
@camchenry camchenry deleted the 05-27-refactor_parser_replace_peek_with_lookahead_in_parsing_delimited_lists branch August 17, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants