Skip to content

refactor(parser): remove peek in parsing delimited lists#11336

Closed
camchenry wants to merge 1 commit into05-27-refactor_parser_remove_lexer_lookahead_in_module_parsingfrom
05-27-refactor_parser_remove_peek_in_parsing_delimited_lists
Closed

refactor(parser): remove peek in parsing delimited lists#11336
camchenry wants to merge 1 commit into05-27-refactor_parser_remove_lexer_lookahead_in_module_parsingfrom
05-27-refactor_parser_remove_peek_in_parsing_delimited_lists

Conversation

@camchenry
Copy link
Member

No description provided.

Copy link
Member Author

camchenry commented May 27, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 27, 2025
@camchenry camchenry force-pushed the 05-27-refactor_parser_remove_lexer_lookahead_in_module_parsing branch from 1323dbb to f85a6a4 Compare May 27, 2025 21:07
@camchenry camchenry force-pushed the 05-27-refactor_parser_remove_peek_in_parsing_delimited_lists branch from e30ee32 to c41b0dc Compare May 27, 2025 21:07
@codspeed-hq
Copy link

codspeed-hq bot commented May 27, 2025

CodSpeed Instrumentation Performance Report

Merging #11336 will create unknown performance changes

Comparing 05-27-refactor_parser_remove_peek_in_parsing_delimited_lists (c41b0dc) with 05-27-refactor_parser_remove_lexer_lookahead_in_module_parsing (f85a6a4)

Summary

🆕 38 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[RadixUIAdoptionSection.jsx] N/A 132.2 µs N/A
🆕 codegen[binder.ts] N/A 4.8 ms N/A
🆕 codegen[cal.com.tsx] N/A 38.9 ms N/A
🆕 codegen[react.development.js] N/A 2.2 ms N/A
🆕 formatter[RadixUIAdoptionSection.jsx] N/A 300.3 µs N/A
🆕 formatter[binder.ts] N/A 18.8 ms N/A
🆕 formatter[cal.com.tsx] N/A 142.9 ms N/A
🆕 formatter[react.development.js] N/A 9.2 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.8 µs N/A
🆕 lexer[binder.ts] N/A 961.2 µs N/A
🆕 lexer[cal.com.tsx] N/A 6 ms N/A
🆕 lexer[react.development.js] N/A 397 µs N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.8 ms N/A
🆕 linter[binder.ts] N/A 148.9 ms N/A
🆕 linter[cal.com.tsx] N/A 1.3 s N/A
🆕 linter[react.development.js] N/A 54.6 ms N/A
🆕 mangler[RadixUIAdoptionSection.jsx] N/A 14.2 µs N/A
🆕 mangler[binder.ts] N/A 797.3 µs N/A
🆕 mangler[cal.com.tsx] N/A 3 ms N/A
🆕 mangler[react.development.js] N/A 282.5 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@camchenry camchenry closed this May 27, 2025
@camchenry camchenry deleted the 05-27-refactor_parser_remove_peek_in_parsing_delimited_lists branch August 17, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant