perf(parser): check_identifier match on Kind not &str#11322
Merged
graphite-app[bot] merged 1 commit intomainfrom May 27, 2025
Merged
Conversation
github-actions
bot
added
A-parser
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11322 will not alter performanceComparing Summary
|
camchenry
approved these changes
May 27, 2025
Contributor
Merge activity
|
Small optimization. `ParserImpl::check_identifier` check if the identifier is `async` or `yield` by comparing `kind == Kind::Async` instead of `name == "async"`. Comparing `Kind`s is cheaper than string comparison. Also: * Receive `ctx` as a parameter, to avoid `parse_function_id` having to temporarily overwrite `self.ctx` and then set it back again. * Don't take `span` as a parameter, because it can be obtained from `self.cur_token().span()`, and this is on a cold path.
graphite-app
bot
force-pushed
the
05-27-perf_parser_avoid_work_in_parse_function_id_
branch
from
41aebd6 to
552a977
Compare
graphite-app
bot
force-pushed
the
05-27-perf_parser_check_identifier_match_on_kind_not_str_
branch
from
a18b48b to
2372f00
Compare
Base automatically changed from
05-27-perf_parser_avoid_work_in_parse_function_id_
to
main
May 27, 2025 15:27
graphite-app
bot
deleted the
05-27-perf_parser_check_identifier_match_on_kind_not_str_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small optimization.
ParserImpl::check_identifiercheck if the identifier isasyncoryieldby comparingkind == Kind::Asyncinstead ofname == "async". ComparingKinds is cheaper than string comparison.Also:
ctxas a parameter, to avoidparse_function_idhaving to temporarily overwriteself.ctxand then set it back again.spanas a parameter, because it can be obtained fromself.cur_token().span(), and this is on a cold path.