Skip to content

perf(parser): remove branch parsing class elements#11319

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-26-perf_parser_remove_branch_parsing_class_elements
May 27, 2025
Merged

perf(parser): remove branch parsing class elements#11319
graphite-app[bot] merged 1 commit intomainfrom
05-26-perf_parser_remove_branch_parsing_class_elements

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 27, 2025

Small optimization. No need to check for Kind::RCurly, unless it's preceded by Kind::Semicolon. In any other circumstances, parse_normal_list would have already found the } and would not have called the closure, so the check is redundant - p.at(Kind::RCurly) will always be false.

Copy link
Member Author

overlookmotel commented May 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance labels May 27, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 27, 2025 10:59
@codspeed-hq
Copy link

codspeed-hq bot commented May 27, 2025

CodSpeed Instrumentation Performance Report

Merging #11319 will degrade performances by 13.25%

Comparing 05-26-perf_parser_remove_branch_parsing_class_elements (6eda38a) with main (a404b2c)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3 ms 3.5 ms -13.25%

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label May 27, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented May 27, 2025

Merge activity

Small optimization. No need to check for `Kind::RCurly`, unless it's preceded by `Kind::Semicolon`. In any other circumstances, `parse_normal_list` would have already found the `}` and would not have called the closure, so the check is redundant - `p.at(Kind::RCurly)` will always be `false`.
@graphite-app graphite-app bot force-pushed the 05-26-perf_parser_remove_branch_parsing_class_elements branch from 6d83ca7 to 6eda38a Compare May 27, 2025 15:18
@graphite-app graphite-app bot merged commit 6eda38a into main May 27, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 27, 2025
@graphite-app graphite-app bot deleted the 05-26-perf_parser_remove_branch_parsing_class_elements branch May 27, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants