Skip to content

refactor(allocator/vec): simplify comparison macros#11178

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-19-refactor_allocator_vec_simplify_comparison_macros
May 20, 2025
Merged

refactor(allocator/vec): simplify comparison macros#11178
graphite-app[bot] merged 1 commit intomainfrom
05-19-refactor_allocator_vec_simplify_comparison_macros

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 19, 2025

Pure refactor. Simplify the macros which generate PartialEq impls for Vec, by removing repeated parts, removing unnecessary lifetimes, and renaming generic types to more conventional T and U, rather than A and B.

Copy link
Member Author

overlookmotel commented May 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label May 19, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 19, 2025

CodSpeed Instrumentation Performance Report

Merging #11178 will create unknown performance changes

Comparing 05-19-refactor_allocator_vec_simplify_comparison_macros (f081757) with main (31c5169)

Summary

🆕 38 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[RadixUIAdoptionSection.jsx] N/A 132.6 µs N/A
🆕 codegen[binder.ts] N/A 4.8 ms N/A
🆕 codegen[cal.com.tsx] N/A 38.9 ms N/A
🆕 codegen[react.development.js] N/A 2.2 ms N/A
🆕 formatter[RadixUIAdoptionSection.jsx] N/A 299.9 µs N/A
🆕 formatter[binder.ts] N/A 15.8 ms N/A
🆕 formatter[cal.com.tsx] N/A 128.4 ms N/A
🆕 formatter[react.development.js] N/A 8.1 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.8 µs N/A
🆕 lexer[binder.ts] N/A 961.2 µs N/A
🆕 lexer[cal.com.tsx] N/A 6 ms N/A
🆕 lexer[react.development.js] N/A 397.2 µs N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.8 ms N/A
🆕 linter[binder.ts] N/A 148.3 ms N/A
🆕 linter[cal.com.tsx] N/A 1.3 s N/A
🆕 linter[react.development.js] N/A 54.4 ms N/A
🆕 mangler[RadixUIAdoptionSection.jsx] N/A 14.1 µs N/A
🆕 mangler[binder.ts] N/A 798.1 µs N/A
🆕 mangler[cal.com.tsx] N/A 3 ms N/A
🆕 mangler[react.development.js] N/A 282.6 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@overlookmotel overlookmotel marked this pull request as ready for review May 19, 2025 22:28
@overlookmotel overlookmotel requested a review from Dunqing May 19, 2025 22:29
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label May 20, 2025
Copy link
Member

Dunqing commented May 20, 2025

Merge activity

Pure refactor. Simplify the macros which generate `PartialEq` impls for `Vec`, by removing repeated parts, removing unnecessary lifetimes, and renaming generic types to more conventional `T` and `U`, rather than `A` and `B`.
@graphite-app graphite-app bot force-pushed the 05-19-refactor_allocator_vec_remove_rawvec_with_capacity_zeroed_in_ branch from db73c4d to b4b7d09 Compare May 20, 2025 01:21
@graphite-app graphite-app bot force-pushed the 05-19-refactor_allocator_vec_simplify_comparison_macros branch from b4a6114 to f081757 Compare May 20, 2025 01:22
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 20, 2025
Base automatically changed from 05-19-refactor_allocator_vec_remove_rawvec_with_capacity_zeroed_in_ to main May 20, 2025 01:27
@graphite-app graphite-app bot merged commit f081757 into main May 20, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-19-refactor_allocator_vec_simplify_comparison_macros branch May 20, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants