Skip to content

refactor(allocator/vec): remove RawVec::with_capacity_zeroed_in#11177

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-19-refactor_allocator_vec_remove_rawvec_with_capacity_zeroed_in_
May 20, 2025
Merged

refactor(allocator/vec): remove RawVec::with_capacity_zeroed_in#11177
graphite-app[bot] merged 1 commit intomainfrom
05-19-refactor_allocator_vec_remove_rawvec_with_capacity_zeroed_in_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 19, 2025

Pure refactor. Remove RawVec::with_capacity_zeroed_in. It's not exposed in public API, and not used internally either.

Copy link
Member Author

overlookmotel commented May 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label May 19, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 19, 2025

CodSpeed Instrumentation Performance Report

Merging #11177 will degrade performances by 11.38%

Comparing 05-19-refactor_allocator_vec_remove_rawvec_with_capacity_zeroed_in_ (b4b7d09) with 05-19-refactor_allocator_vec_re-order_arguments_to_rawvec_from_raw_parts_in_ (44630a9)

Summary

❌ 1 regressions
✅ 33 untouched benchmarks
🆕 4 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.8 ms N/A
🆕 linter[binder.ts] N/A 148.3 ms N/A
🆕 linter[cal.com.tsx] N/A 1.3 s N/A
🆕 linter[react.development.js] N/A 54.4 ms N/A
mangler[cal.com.tsx] 2.7 ms 3 ms -11.38%

@overlookmotel overlookmotel marked this pull request as ready for review May 19, 2025 22:27
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label May 20, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented May 20, 2025

Merge activity

…1177)

Pure refactor. Remove `RawVec::with_capacity_zeroed_in`. It's not exposed in public API, and not used internally either.
@graphite-app graphite-app bot force-pushed the 05-19-refactor_allocator_vec_re-order_arguments_to_rawvec_from_raw_parts_in_ branch from 8765e4d to 44630a9 Compare May 20, 2025 01:21
@graphite-app graphite-app bot force-pushed the 05-19-refactor_allocator_vec_remove_rawvec_with_capacity_zeroed_in_ branch from db73c4d to b4b7d09 Compare May 20, 2025 01:21
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 20, 2025
Base automatically changed from 05-19-refactor_allocator_vec_re-order_arguments_to_rawvec_from_raw_parts_in_ to main May 20, 2025 01:27
@graphite-app graphite-app bot merged commit b4b7d09 into main May 20, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-19-refactor_allocator_vec_remove_rawvec_with_capacity_zeroed_in_ branch May 20, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants