perf(lexer): tighten search loops#11118
Merged
graphite-app[bot] merged 1 commit intomainfrom May 18, 2025
Merged
Conversation
github-actions
bot
added
A-parser
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11118 will improve performances by 11.94%Comparing Summary
Benchmarks breakdown
|
Member
Merge activity
|
Use slice iterators in the tight search loops in `byte_search!` macro. This shaves off 2 instructions from each turn of the loop, and makes "no match" the default path on each iteration, which is better as search spends most of its time running through bytes that *don't* match, until it find one that does. https://godbolt.org/z/99zo8esf8 +2% on one of lexer benchmarks. It turns out idiomatic Rust is faster than C-style pointer manipulation! Who'd have thought it?
graphite-app
bot
force-pushed
the
05-18-perf_lexer_use_offset_from_and_offset_from_unsigned_for_pointer_comparisons
branch
from
57f28e4 to
261e78b
Compare
graphite-app
bot
force-pushed
the
05-18-perf_lexer_tighten_search_loops
branch
from
04c1fed to
0f9b43e
Compare
Base automatically changed from
05-18-perf_lexer_use_offset_from_and_offset_from_unsigned_for_pointer_comparisons
to
main
May 18, 2025 16:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use slice iterators in the tight search loops in
byte_search!macro.This shaves off 2 instructions from each turn of the loop, and makes "no match" the default path on each iteration, which is better as search spends most of its time running through bytes that don't match, until it find one that does.
https://godbolt.org/z/99zo8esf8
+2% on one of lexer benchmarks.
It turns out idiomatic Rust is faster than C-style pointer manipulation! Who'd have thought it?