perf(lexer): use offset_from and offset_from_unsigned for pointer comparisons#11116
Merged
graphite-app[bot] merged 1 commit intomainfrom May 18, 2025
Conversation
github-actions
bot
added
A-parser
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11116 will improve performances by 12.55%Comparing Summary
Benchmarks breakdown
|
Contributor
Merge activity
|
… comparisons (#11116) Lexer use `offset_from` and `offset_from_unsigned` pointer methods rather than comparing pointers as `usize`s. This utilizes the `PointerExt` trait introduced in #11095. This change tells the compiler "both these pointers are into the same object, and origin pointer is before target pointer", which gives it more information for optimization, and alias analysis. This change also allows simplifying `Source` a little - we now almost entirely now deal in `SourcePosition`s, rather than a mix of `SourcePosition`s, raw pointers, and `ptr as usize`. Tiny improvement on lexer benchmarks. Interestingly, it seems to produce a consistent ~1% speed-up in the byte handler for `/`. It seems to particularly have a positive effect on lexing single-line comments, for some reason.
graphite-app
bot
force-pushed
the
05-18-perf_lexer_use_offset_from_and_offset_from_unsigned_for_pointer_comparisons
branch
from
57f28e4 to
261e78b
Compare
graphite-app
bot
deleted the
05-18-perf_lexer_use_offset_from_and_offset_from_unsigned_for_pointer_comparisons
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lexer use
offset_fromandoffset_from_unsignedpointer methods rather than comparing pointers asusizes.This utilizes the
PointerExttrait introduced in #11095. This change tells the compiler "both these pointers are into the same object, and origin pointer is before target pointer", which gives it more information for optimization, and alias analysis.This change also allows simplifying
Sourcea little - we now almost entirely now deal inSourcePositions, rather than a mix ofSourcePositions, raw pointers, andptr as usize.Tiny improvement on lexer benchmarks. Interestingly, it seems to produce a consistent ~1% speed-up in the byte handler for
/. It seems to particularly have a positive effect on lexing single-line comments, for some reason.