Skip to content

ci(miri): fix Miri#11092

Merged
overlookmotel merged 1 commit intomainfrom
05-17-fix_allocator_vec_fix_lint_error_in_miri
May 17, 2025
Merged

ci(miri): fix Miri#11092
overlookmotel merged 1 commit intomainfrom
05-17-fix_allocator_vec_fix_lint_error_in_miri

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 17, 2025

Miri is failing on main. It seems to have started with #11088, though that could be a coincidence - maybe it's just latest nightly made some change which broke Miri.

2 things are causing the fails:

  1. "fatal error: cross-interpreting doctests is not currently supported by Miri".
  2. A lint error that only occurs on nightly in Vec::append_elements.

Fix (1) by disabling doc tests.

Fix (2) by changing the code. The #[allow] attribute is needed because the amended code triggers a different clippy warning on stable!

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label May 17, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 17, 2025

CodSpeed Instrumentation Performance Report

Merging #11092 will not alter performance

Comparing 05-17-fix_allocator_vec_fix_lint_error_in_miri (05aa064) with main (2f05c54)

Summary

✅ 36 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review May 17, 2025 11:36
@overlookmotel overlookmotel force-pushed the 05-17-fix_allocator_vec_fix_lint_error_in_miri branch from a52f12e to 239a967 Compare May 17, 2025 11:38
@Boshen
Copy link
Member

Boshen commented May 17, 2025

Shall we remove --doc from miri test? Feels like a bug in nightly.

@overlookmotel overlookmotel force-pushed the 05-17-fix_allocator_vec_fix_lint_error_in_miri branch from 239a967 to 05aa064 Compare May 17, 2025 11:52
@overlookmotel overlookmotel changed the title fix(allocator/vec): fix lint error in Miri ci(miri): fix Miri May 17, 2025
@overlookmotel overlookmotel requested a review from Boshen May 17, 2025 11:55
@overlookmotel
Copy link
Member Author

overlookmotel commented May 17, 2025

Shall we remove --doc from miri test? Feels like a bug in nightly.

Done. Can I ask what was the reason you added --doc in #11088? As far as I can see, doc tests already run by default. --doc causes it to run only the doc tests.

@overlookmotel
Copy link
Member Author

I'm not completely sure this is the right way to fix, but I'm going to merge to unblock the merging of other PRs. @Boshen please come back if I've done the wrong thing.

@overlookmotel overlookmotel merged commit f0b76e8 into main May 17, 2025
33 checks passed
@overlookmotel overlookmotel deleted the 05-17-fix_allocator_vec_fix_lint_error_in_miri branch May 17, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants