refactor(rust)!: clippy avoid-breaking-exported-api = false

[Boshen]

No description provided.

[Boshen]

• refactor(rust)!: clippy avoid-breaking-exported-api = false #11088 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR refactors several parts of the codebase, primarily updating function signatures and simplifying return types, while also removing some error‐handling paths to streamline configuration building. Key changes include:

• Replacing chains using .and_then with .map in multiple rule modules to eliminate Option wrapping.
• Changing build() methods to return configuration objects directly instead of Results.
• Updating several methods’ receivers from &self to self in const contexts and making minor clippy suppression adjustments.

Reviewed Changes

Copilot reviewed 47 out of 47 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/oxc_linter/src/rules/jest/no_restricted_matchers.rs	Updated matcher compilation from optional to direct hash map return.
crates/oxc_linter/src/rules/jest/no_restricted_jest_methods.rs	Similar refactor for jest methods matcher compilation.
crates/oxc_linter/src/rules/jest/no_large_snapshots.rs	Changed snapshot allowed matchers chain accordingly.
crates/oxc_linter/src/loader/mod.rs	Removed load_str function to simplify file loading.
crates/oxc_linter/src/config/config_builder.rs	Switched build() to return Config directly, updating error handling.
crates/oxc_language_server/src/linter/server_linter.rs	Adjusted build() usage by removing expect() calls.
crates/oxc_isolated_declarations/src/signatures.rs	Changed transform_ts_signatures receiver from mutable to immutable.
crates/oxc_isolated_declarations/src/enum.rs	Updated transform_ts_enum_declaration to always return a Declaration.
crates/oxc_formatter/src/options.rs & crates/oxc_ast	Changed const method signatures to take self instead of &self.
apps/oxlint/src/lint.rs	Updated config builder handling by removing Result unwrapping.
.clippy.toml	Set avoid-breaking-exported-api to false.

Comments suppressed due to low confidence (11)

crates/oxc_linter/src/loader/mod.rs:22

• The removal of the load_str function streamlines file loading; ensure that any external dependencies or tests relying on it are updated accordingly.

pub fn load_str<'a, P: AsRef<Path>>(...) -> Result<Vec<JavaScriptSource<'a>>, LoadError> {

crates/oxc_linter/src/rules/jest/no_restricted_matchers.rs:85

• The change from .and_then to .map with Self::compile_restricted_matchers removes the Option wrapper; verify that downstream code correctly handles the always-present hash map.

.map(Self::compile_restricted_matchers)

crates/oxc_linter/src/rules/jest/no_restricted_jest_methods.rs:69

• Replacing .and_then with .map in the restricted jest methods chain alters the expected return type; ensure that the direct hash map fits all intended usages.

.map(Self::compile_restricted_jest_methods)

crates/oxc_linter/src/rules/jest/no_large_snapshots.rs:158

• Refactoring from .and_then to .map in compiling allowed snapshots simplifies the chain; confirm that this change does not bypass any required error handling.

.map(Self::compile_allowed_snapshots)

crates/oxc_linter/src/config/config_builder.rs:295

• Changing build() to return a Config directly instead of a Result affects error propagation; verify that configuration errors are handled appropriately at higher layers.

pub fn build(self) -> Config {

crates/oxc_language_server/src/linter/server_linter.rs:64

• Removing the expect() call in favor of directly calling build() aligns with the updated build() signature; ensure that configuration errors are managed downstream.

let base_config = config_builder.build();

crates/oxc_isolated_declarations/src/signatures.rs:14

• Changing the method receiver from mutable to immutable suggests that transform_ts_signatures does not modify internal state; please confirm that this change is intended and does not affect functionality.

pub fn transform_ts_signatures(&self, signatures: &mut ArenaVec<'a, TSSignature<'a>>) {

crates/oxc_isolated_declarations/src/enum.rs:21

• Modifying transform_ts_enum_declaration to return a Declaration directly (instead of Option) simplifies its usage; ensure that all callers adjust to the non-optional return value.

pub fn transform_ts_enum_declaration(&self, decl: &TSEnumDeclaration<'a>) -> Declaration<'a> {

crates/oxc_formatter/src/options.rs:118

• Refactoring const methods to take self instead of &self improves clarity if the type implements Copy; verify that these type changes are safe and cause no semantic differences.

pub const fn is_tab(self) -> bool {

apps/oxlint/src/lint.rs:251

• Switching from handling a Result via expect() to a direct build() call alters error handling; ensure that any configuration failures are properly addressed in the call chain.

let lint_config = config_builder.build();

.clippy.toml:1

• Setting avoid-breaking-exported-api to false can affect API stability; confirm that this decision is documented and aligns with the project’s long-term design goals.

avoid-breaking-exported-api = false

[graphite-app]

Merge activity

• May 16, 10:13 PM EDT: Boshen added this pull request to the Graphite merge queue.
• May 16, 10:28 PM EDT: Merged by the Graphite merge queue.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #11088 will not alter performance

_{Comparing 05-17-refactor_rust_clippy_avoid-breaking-exported-api_false (5d9344f) with main (8f8d823)}

Summary

✅ 36 untouched benchmarks