Skip to content

perf(parser): use 8 bits for each Token flag#11046

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-14-perf_parser_use_8_bits_for_each_token_flag
May 15, 2025
Merged

perf(parser): use 8 bits for each Token flag#11046
graphite-app[bot] merged 1 commit intomainfrom
05-14-perf_parser_use_8_bits_for_each_token_flag

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 14, 2025

Use 8 bits for each of the boolean flags in Token, so they can be read/written as bools, avoiding bitwise operations.

@github-actions github-actions bot added A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance labels May 14, 2025
Copy link
Member Author

overlookmotel commented May 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented May 14, 2025

CodSpeed Instrumentation Performance Report

Merging #11046 will not alter performance

Comparing 05-14-perf_parser_use_8_bits_for_each_token_flag (80c2a5b) with main (4e5c73b)

Summary

✅ 36 untouched benchmarks

@overlookmotel
Copy link
Member Author

Small positive effect on parser benchmarks.

@overlookmotel overlookmotel marked this pull request as ready for review May 14, 2025 19:33
@graphite-app graphite-app bot changed the base branch from 05-14-refactor_parser_token_set_has_separator_take_bool_ to graphite-base/11046 May 15, 2025 08:09
@graphite-app graphite-app bot force-pushed the 05-14-perf_parser_use_8_bits_for_each_token_flag branch from 0930885 to 4d53cb2 Compare May 15, 2025 08:16
@graphite-app graphite-app bot force-pushed the graphite-base/11046 branch from 6e01ae6 to de3035a Compare May 15, 2025 08:16
@graphite-app graphite-app bot changed the base branch from graphite-base/11046 to main May 15, 2025 08:16
@graphite-app graphite-app bot force-pushed the 05-14-perf_parser_use_8_bits_for_each_token_flag branch from 4d53cb2 to af140ac Compare May 15, 2025 08:16
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 15, 2025
Copy link
Member

Boshen commented May 15, 2025

Merge activity

Use 8 bits for each of the boolean flags in `Token`, so they can be read/written as `bool`s, avoiding bitwise operations.
@graphite-app graphite-app bot force-pushed the 05-14-perf_parser_use_8_bits_for_each_token_flag branch from af140ac to 80c2a5b Compare May 15, 2025 09:29
@graphite-app graphite-app bot merged commit 80c2a5b into main May 15, 2025
26 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 15, 2025
@graphite-app graphite-app bot deleted the 05-14-perf_parser_use_8_bits_for_each_token_flag branch May 15, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants