Skip to content

refactor(parser): Token::set_has_separator take bool#11041

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-14-refactor_parser_token_set_has_separator_take_bool_
May 15, 2025
Merged

refactor(parser): Token::set_has_separator take bool#11041
graphite-app[bot] merged 1 commit intomainfrom
05-14-refactor_parser_token_set_has_separator_take_bool_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 14, 2025

Pure refactor. Token::set_has_separator method take a bool param, for consistency with the other Token setter methods.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 14, 2025
Copy link
Member Author

overlookmotel commented May 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review May 14, 2025 16:41
@codspeed-hq
Copy link

codspeed-hq bot commented May 14, 2025

CodSpeed Instrumentation Performance Report

Merging #11041 will not alter performance

Comparing 05-14-refactor_parser_token_set_has_separator_take_bool_ (de3035a) with main (c1e6c9b)

Summary

✅ 36 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 15, 2025
Copy link
Member

Boshen commented May 15, 2025

Merge activity

Pure refactor. `Token::set_has_separator` method take a `bool` param, for consistency with the other `Token` setter methods.
@graphite-app graphite-app bot force-pushed the 05-14-refactor_lexer_re-order_token_methods branch from 4647f8e to 47c624b Compare May 15, 2025 08:08
@graphite-app graphite-app bot force-pushed the 05-14-refactor_parser_token_set_has_separator_take_bool_ branch from 6e01ae6 to de3035a Compare May 15, 2025 08:09
Base automatically changed from 05-14-refactor_lexer_re-order_token_methods to main May 15, 2025 08:15
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 15, 2025
@graphite-app graphite-app bot merged commit de3035a into main May 15, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 05-14-refactor_parser_token_set_has_separator_take_bool_ branch May 15, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants