refactor(parser): rewrite parse class element#11035
Merged
graphite-app[bot] merged 1 commit intomainfrom May 14, 2025
Merged
Conversation
github-actions
bot
added
A-parser
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the parsing of class element modifiers and updates related tests and diagnostics. Key changes include:
- Refactoring parsing logic to separate handling of static and get/set modifiers in modifiers.rs.
- Removing the deprecated static constructor diagnostic in diagnostics.rs.
- Updating TypeScript integration tests and snapshots to reflect new handling for duplicate static keywords.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/oxc_parser/src/modifiers.rs | Refactored modifier parsing logic including visibility and token handling. |
| crates/oxc_parser/src/diagnostics.rs | Removed static constructor diagnostic as part of cleanup. |
| crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs | Removed a now-redundant test case regarding static modifier syntax. |
| crates/oxc_codegen/tests/integration/ts.rs | Added a test case with multiple static keywords in a class. |
| crates/oxc_codegen/tests/integration/snapshots/ts.snap and minify.snap | Updated snapshots reflecting the handling of duplicate static keywords. |
Boshen
force-pushed
the
05-14-refactor_parser_rewrite_parse_class_element
branch
from
3fc54c5 to
c5ef692
Compare
CodSpeed Instrumentation Performance ReportMerging #11035 will not alter performanceComparing Summary
|
Boshen
force-pushed
the
05-14-refactor_parser_rewrite_parse_class_element
branch
from
c5ef692 to
4d3fe36
Compare
Member
Author
Merge activity
|
graphite-app
bot
force-pushed
the
05-14-refactor_parser_rewrite_parse_class_element
branch
from
4d3fe36 to
751876b
Compare
graphite-app
bot
deleted the
05-14-refactor_parser_rewrite_parse_class_element
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #10942
closes #11010