Skip to content

refactor(ast/estree): remove custom serializer for Elision#10965

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-12-refactor_ast_estree_remove_custom_serializer_for_elision_
May 12, 2025
Merged

refactor(ast/estree): remove custom serializer for Elision#10965
graphite-app[bot] merged 1 commit intomainfrom
05-12-refactor_ast_estree_remove_custom_serializer_for_elision_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 12, 2025

Remove ElisionConverter custom serializer. Just use Null instead.

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 12, 2025
Copy link
Member Author

overlookmotel commented May 12, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review May 12, 2025 12:21
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 12, 2025
Copy link
Member Author

overlookmotel commented May 12, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented May 12, 2025

CodSpeed Instrumentation Performance Report

Merging #10965 will not alter performance

Comparing 05-12-refactor_ast_estree_remove_custom_serializer_for_elision_ (08f1f3f) with main (d01a47b)

Summary

✅ 36 untouched benchmarks

@graphite-app graphite-app bot changed the base branch from 05-09-refactor_ast_estree_simplify_custom_serializers_for_formalparameters_ to graphite-base/10965 May 12, 2025 12:24
@graphite-app graphite-app bot changed the base branch from graphite-base/10965 to main May 12, 2025 12:32
Remove `ElisionConverter` custom serializer. Just use `Null` instead.
@graphite-app graphite-app bot force-pushed the 05-12-refactor_ast_estree_remove_custom_serializer_for_elision_ branch from 8054ec0 to 08f1f3f Compare May 12, 2025 12:32
@graphite-app graphite-app bot merged commit 08f1f3f into main May 12, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-12-refactor_ast_estree_remove_custom_serializer_for_elision_ branch May 12, 2025 12:39
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant