Skip to content

refactor(ast/estree): simplify custom serializers for FormalParameters#10964

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-09-refactor_ast_estree_simplify_custom_serializers_for_formalparameters_
May 12, 2025
Merged

refactor(ast/estree): simplify custom serializers for FormalParameters#10964
graphite-app[bot] merged 1 commit intomainfrom
05-09-refactor_ast_estree_simplify_custom_serializers_for_formalparameters_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 12, 2025

Simplify custom serializers for FormalParameters, by using ConcatElement trait.

Copy link
Member Author

overlookmotel commented May 12, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 12, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 12, 2025 12:18
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 12, 2025
Copy link
Member Author

overlookmotel commented May 12, 2025

Merge activity

…rs` (#10964)

Simplify custom serializers for `FormalParameters`, by using `ConcatElement` trait.
@graphite-app graphite-app bot force-pushed the 05-09-refactor_ast_estree_simplify_custom_serializers_for_formalparameters_ branch from 7c975e5 to d01a47b Compare May 12, 2025 12:24
@codspeed-hq
Copy link

codspeed-hq bot commented May 12, 2025

CodSpeed Instrumentation Performance Report

Merging #10964 will not alter performance

Comparing 05-09-refactor_ast_estree_simplify_custom_serializers_for_formalparameters_ (d01a47b) with main (bfc6b9a)

Summary

✅ 36 untouched benchmarks

@graphite-app graphite-app bot merged commit d01a47b into main May 12, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-09-refactor_ast_estree_simplify_custom_serializers_for_formalparameters_ branch May 12, 2025 12:31
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant