Skip to content

fix(ast/estree): fix optional field of TSMappedType in TS-ESTree AST#10874

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-07-fix_ast_estree_fix_optional_field_of_tsmappedtype_in_ts-estree_ast
May 7, 2025
Merged

fix(ast/estree): fix optional field of TSMappedType in TS-ESTree AST#10874
graphite-app[bot] merged 1 commit intomainfrom
05-07-fix_ast_estree_fix_optional_field_of_tsmappedtype_in_ts-estree_ast

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 7, 2025

Part of #9705.

Recent changes in TS-ESLint made TSMappedType's optional field default to false instead of null. Update our TS-ESTree AST to match it.

@github-actions github-actions bot added the A-ast Area - AST label May 7, 2025
@github-actions github-actions bot added the C-bug Category - Bug label May 7, 2025
Copy link
Member Author

overlookmotel commented May 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review May 7, 2025 15:56
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 7, 2025
Copy link
Member Author

overlookmotel commented May 7, 2025

Merge activity

  • May 7, 11:57 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 7, 12:02 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • May 7, 12:35 PM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #10873.
  • May 7, 12:38 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 7, 12:45 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • May 7, 12:52 PM EDT: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from 05-07-fix_ast_estree_remove_tsimporttypeoptions_custom_serializer to graphite-base/10874 May 7, 2025 15:58
@codspeed-hq
Copy link

codspeed-hq bot commented May 7, 2025

CodSpeed Instrumentation Performance Report

Merging #10874 will not alter performance

Comparing 05-07-fix_ast_estree_fix_optional_field_of_tsmappedtype_in_ts-estree_ast (e7228fa) with main (6f0638a)

Summary

✅ 36 untouched benchmarks

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 7, 2025
@overlookmotel overlookmotel force-pushed the 05-07-fix_ast_estree_fix_optional_field_of_tsmappedtype_in_ts-estree_ast branch from c088167 to 9684c02 Compare May 7, 2025 16:37
@overlookmotel overlookmotel force-pushed the graphite-base/10874 branch from 2149748 to 6f0638a Compare May 7, 2025 16:37
@overlookmotel overlookmotel changed the base branch from graphite-base/10874 to 05-07-fix_ast_estree_remove_tsimporttypeoptions_custom_serializer May 7, 2025 16:37
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 7, 2025
Base automatically changed from 05-07-fix_ast_estree_remove_tsimporttypeoptions_custom_serializer to main May 7, 2025 16:45
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 7, 2025
…AST (#10874)

Part of #9705.

Recent changes in TS-ESLint made `TSMappedType`'s `optional` field default to `false` instead of `null`. Update our TS-ESTree AST to match it.
@graphite-app graphite-app bot force-pushed the 05-07-fix_ast_estree_fix_optional_field_of_tsmappedtype_in_ts-estree_ast branch from 9684c02 to e7228fa Compare May 7, 2025 16:46
@graphite-app graphite-app bot merged commit e7228fa into main May 7, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 05-07-fix_ast_estree_fix_optional_field_of_tsmappedtype_in_ts-estree_ast branch May 7, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant