Skip to content

feat(parser): accessor modifier cannot be used with readonly and declare modifier.#10870

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-07-feat_parser_accessor_modifier_cannot_be_used_with_readonly_and_declare_modifier
May 8, 2025
Merged

feat(parser): accessor modifier cannot be used with readonly and declare modifier.#10870
graphite-app[bot] merged 1 commit intomainfrom
05-07-feat_parser_accessor_modifier_cannot_be_used_with_readonly_and_declare_modifier

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented May 7, 2025

closes #10837

These are syntax errors:

class Foo {
    readonly accessor a: any;
    declare accessor b: any;
}

@github-actions github-actions bot added A-parser Area - Parser C-enhancement Category - New feature or request labels May 7, 2025
Copy link
Member Author

Boshen commented May 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 7, 2025
@Boshen Boshen changed the title feat(parser): 'accessor' modifier cannot be used with 'readonly' and declare modifier. feat(parser): 'accessor' modifier cannot be used with readonly and declare modifier. May 7, 2025
@Boshen Boshen changed the title feat(parser): 'accessor' modifier cannot be used with readonly and declare modifier. feat(parser): accessor modifier cannot be used with readonly and declare modifier. May 7, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 7, 2025

CodSpeed Instrumentation Performance Report

Merging #10870 will not alter performance

Comparing 05-07-feat_parser_accessor_modifier_cannot_be_used_with_readonly_and_declare_modifier (539eb9d) with main (234abd4)

Summary

✅ 36 untouched benchmarks

Base automatically changed from 05-07-fix_parser_fix_rhs_precedence_while_parsing_privateinexpression_ to main May 7, 2025 14:51
@graphite-app
Copy link
Contributor

graphite-app bot commented May 8, 2025

Merge activity

  • May 7, 9:49 PM EDT: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • May 7, 9:49 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 8, 4:39 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • May 8, 4:46 AM EDT: Merged by the Graphite merge queue.

@Boshen Boshen force-pushed the 05-07-feat_parser_accessor_modifier_cannot_be_used_with_readonly_and_declare_modifier branch 2 times, most recently from 94245b2 to 3e3c5ca Compare May 8, 2025 05:50
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label May 8, 2025
@Boshen Boshen force-pushed the 05-07-feat_parser_accessor_modifier_cannot_be_used_with_readonly_and_declare_modifier branch from 3e3c5ca to fe6e524 Compare May 8, 2025 08:33
…`declare` modifier. (#10870)

closes #10837

These are syntax errors:

```ts
class Foo {
    readonly accessor a: any;
    declare accessor b: any;
}
```
@graphite-app graphite-app bot force-pushed the 05-07-feat_parser_accessor_modifier_cannot_be_used_with_readonly_and_declare_modifier branch from fe6e524 to 539eb9d Compare May 8, 2025 08:40
@graphite-app graphite-app bot merged commit 539eb9d into main May 8, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 05-07-feat_parser_accessor_modifier_cannot_be_used_with_readonly_and_declare_modifier branch May 8, 2025 08:46
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AST issue for declare accessor

1 participant