fix(parser): fix rhs precedence while parsing PrivateInExpression#10866
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a parsing bug in the handling of PrivateInExpression by adjusting the right-hand side operator precedence.
- Changes the precedence argument in parse_binary_expression_or_higher from Precedence::Lowest to Precedence::Compare in the parser.
- Adds an integration test to validate the correct parsing of expressions involving private identifiers.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/oxc_parser/src/js/expression.rs | Updates parser behavior for PrivateInExpression precedence handling |
| crates/oxc_codegen/tests/integration/ts.rs | Adds integration test to verify the updated behavior |
CodSpeed Instrumentation Performance ReportMerging #10866 will not alter performanceComparing Summary
|
9390beb to
c47aedf
Compare
Merge activity
|
c47aedf to
2c05fa1
Compare

fixes #10839