refactor(ast): remove quotes from #[estree(append_to)] attributes#10863
Merged
graphite-app[bot] merged 1 commit intomainfrom May 7, 2025
Merged
Conversation
This was referenced May 7, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
|
Pure refactor, so merging without review. |
CodSpeed Instrumentation Performance ReportMerging #10863 will degrade performances by 100%Comparing Summary
Benchmarks breakdown
|
Member
Merge activity
|
0c37c57 to
9c6c686
Compare
8ab06bb to
0f7e755
Compare
Base automatically changed from
05-07-refactor_ast_estree_use_estree_prepend_to_
to
main
May 7, 2025 14:02
…10863) Pure refactor. Our convention in `#[estree]` attributes is not to quote type or field names. Adjust `#[estree(prepend_to = ...)]` and `#[estree(append_to = ...)]` attrs to follow this convention.
9c6c686 to
805735b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pure refactor. Our convention in
#[estree]attributes is not to quote type or field names. Adjust#[estree(prepend_to = ...)]and#[estree(append_to = ...)]attrs to follow this convention.