Skip to content

refactor(ast/estree): generalize concatenating fields with Concat2#10848

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-07-refactor_ast_estree_generalize_concatenating_fields_with_concat2_
May 7, 2025
Merged

refactor(ast/estree): generalize concatenating fields with Concat2#10848
graphite-app[bot] merged 1 commit intomainfrom
05-07-refactor_ast_estree_generalize_concatenating_fields_with_concat2_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 7, 2025

Pure refactor. Replace AppendTo and AppendToConcat which are used in ESTree serializer to concatenate 2 fields with a more generalized Concat2, which performs both functions.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 7, 2025
Copy link
Member Author

overlookmotel commented May 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented May 7, 2025

CodSpeed Instrumentation Performance Report

Merging #10848 will not alter performance

Comparing 05-07-refactor_ast_estree_generalize_concatenating_fields_with_concat2_ (b16331e) with main (087af52)

Summary

✅ 36 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review May 7, 2025 12:55
@overlookmotel overlookmotel requested a review from leaysgur as a code owner May 7, 2025 12:55
@overlookmotel
Copy link
Member Author

Pure refactor, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 7, 2025
Copy link
Member Author

overlookmotel commented May 7, 2025

Merge activity

  • May 7, 8:56 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 7, 8:56 AM EDT: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • May 7, 8:56 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 7, 9:18 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • May 7, 9:31 AM EDT: Merged by the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 05-07-refactor_ast_estree_generalize_concatenating_fields_with_concat2_ branch from 3b4cfea to ff07cc6 Compare May 7, 2025 13:11
…10848)

Pure refactor. Replace `AppendTo` and `AppendToConcat` which are used in ESTree serializer to concatenate 2 fields with a more generalized `Concat2`, which performs both functions.
@graphite-app graphite-app bot force-pushed the 05-07-refactor_ast_estree_generalize_concatenating_fields_with_concat2_ branch from ff07cc6 to b16331e Compare May 7, 2025 13:25
@graphite-app graphite-app bot merged commit b16331e into main May 7, 2025
27 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 7, 2025
@graphite-app graphite-app bot deleted the 05-07-refactor_ast_estree_generalize_concatenating_fields_with_concat2_ branch May 7, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant