Skip to content

perf(transformer, linter): use format_compact_str! #10753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
May 1, 2025
Merged

perf(transformer, linter): use format_compact_str! #10753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/oxc_linter/src/config/config_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use itertools::Itertools;
use rustc_hash::FxHashSet;

use oxc_diagnostics::OxcDiagnostic;
use oxc_span::CompactStr;
use oxc_span::{CompactStr, format_compact_str};

use crate::{
AllowWarnDeny, LintConfig, LintFilter, LintFilterKind, Oxlintrc, RuleCategory, RuleEnum,
Expand Down Expand Up @@ -364,7 +364,7 @@ fn get_name(plugin_name: &str, rule_name: &str) -> CompactStr {
if plugin_name == "eslint" {
CompactStr::from(rule_name)
} else {
CompactStr::from(format!("{plugin_name}/{rule_name}"))
format_compact_str!("{plugin_name}/{rule_name}")
}
}

Expand Down
4 changes: 2 additions & 2 deletions crates/oxc_transformer_plugins/src/inject_global_variables.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use cow_utils::CowUtils;
use oxc_allocator::Allocator;
use oxc_ast::{AstBuilder, NONE, ast::*};
use oxc_semantic::Scoping;
use oxc_span::{CompactStr, SPAN};
use oxc_span::{CompactStr, SPAN, format_compact_str};
use oxc_syntax::identifier;
use oxc_traverse::{Traverse, TraverseCtx, traverse_mut};

Expand Down Expand Up @@ -64,7 +64,7 @@ impl InjectImport {

fn replace_name(local: &str) -> Option<CompactStr> {
match local.cow_replace('.', "_") {
Cow::Owned(local) => Some(CompactStr::from(format!("$inject_{local}"))),
Cow::Owned(local) => Some(format_compact_str!("$inject_{local}")),
Cow::Borrowed(_) => None,
}
}
Expand Down
Loading