perf(transformer/regexp): do not store parsed regexp#10748
Merged
graphite-app[bot] merged 1 commit intomainfrom May 2, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-transformer
CodSpeed Instrumentation Performance ReportMerging #10748 will not alter performanceComparing Summary
|
Member
Merge activity
|
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
04-30-perf_transformer_regexp_inline_enter_expression_
branch
from
469b98c to
c4c41eb
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
May 1, 2025
Regexp transform do not store the parsed regexp `Pattern` in AST. This has 2 effects: 1. When the regexp does need to be transformed, it avoids converting the `Pattern` back to a string again later on in the transform. 2. When the regexp doesn't need to be transformed, it makes the `RegExpLiteral` faster to print in `oxc_codegen`, again because it avoids converting the `Pattern` back to a string. Only the 1st will show an effect in our benchmarks, because transformer benchmark doesn't include codegen.
graphite-app
bot
force-pushed
the
04-30-perf_transformer_regexp_do_not_store_parsed_regexp
branch
from
d4650a3 to
f3b0a9d
Compare
Regexp transform do not store the parsed regexp `Pattern` in AST. This has 2 effects: 1. When the regexp does need to be transformed, it avoids converting the `Pattern` back to a string again later on in the transform. 2. When the regexp doesn't need to be transformed, it makes the `RegExpLiteral` faster to print in `oxc_codegen`, again because it avoids converting the `Pattern` back to a string. Only the 1st will show an effect in our benchmarks, because transformer benchmark doesn't include codegen.
graphite-app
bot
force-pushed
the
04-30-perf_transformer_regexp_inline_enter_expression_
branch
from
c4c41eb to
fc90298
Compare
graphite-app
bot
force-pushed
the
04-30-perf_transformer_regexp_do_not_store_parsed_regexp
branch
from
f3b0a9d to
dec3c80
Compare
Base automatically changed from
04-30-perf_transformer_regexp_inline_enter_expression_
to
main
May 2, 2025 01:12
graphite-app
bot
deleted the
04-30-perf_transformer_regexp_do_not_store_parsed_regexp
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regexp transform do not store the parsed regexp
Patternin AST.This has 2 effects:
Patternback to a string again later on in the transform.RegExpLiteralfaster to print inoxc_codegen, again because it avoids converting thePatternback to a string.Only the 1st will show an effect in our benchmarks, because transformer benchmark doesn't include codegen.