perf(transformer/regexp): inline enter_expression

[overlookmotel]

In RegExp transform, move logic out of enter_expression and mark it #[inline], to make a fast path for Expressions which are not RegExpLiterals (the vast majority).

[overlookmotel]

• perf(transformer/regexp): do not store parsed regexp #10748
• perf(transformer/regexp): inline enter_expression #10745 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[coderabbitai]

Walkthrough

The changes refactor the implementation of the Traverse trait for the RegExp structure within the codebase. Specifically, the enter_expression method is rewritten to directly check if an expression is a RegExpLiteral. If so, it delegates the transformation logic to a new method called transform_regexp. This new method is responsible for handling the detection of unsupported flags or patterns in regular expression literals and transforming them into a new RegExp(...) constructor call expression if necessary. The transformation logic itself remains unchanged but is now encapsulated within transform_regexp, separating it from the traversal entry point. Additionally, the code now uses an unreachable!() macro for cases where enter_expression is called with a non-RegExpLiteral expression, reflecting a more restricted invocation context. No changes were made to the detection or parsing logic for regular expressions.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4c41eb and fc90298.

📒 Files selected for processing (1)

• crates/oxc_transformer/src/regexp/mod.rs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/oxc_transformer/src/regexp/mod.rs

⏰ Context from checks skipped due to timeout of 90000ms (14)

• GitHub Check: Doc
• GitHub Check: Conformance
• GitHub Check: Test (macos-latest)
• GitHub Check: Test wasm32-wasip1-threads
• GitHub Check: Test NAPI
• GitHub Check: Benchmark (parser)
• GitHub Check: Benchmark (transformer)
• GitHub Check: Benchmark (minifier)
• GitHub Check: Benchmark (codegen)
• GitHub Check: Benchmark (isolated_declarations)
• GitHub Check: Benchmark (formatter)
• GitHub Check: Benchmark (semantic)
• GitHub Check: Build Linter Benchmark
• GitHub Check: Benchmark (lexer)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10745 will not alter performance

_{Comparing 04-30-perf_transformer_regexp_inline_enter_expression_ (fc90298) with main (63f02a8)}

Summary

✅ 36 untouched benchmarks

[overlookmotel]

Weird there's no perf difference. But still it's good practice to reduce the size of enter_expression visitors.

[graphite-app]

Merge activity

• May 1, 9:45 AM EDT: Boshen added this pull request to the Graphite merge queue.
• May 1, 2:18 PM UTC: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason.
• May 1, 8:19 PM EDT: Boshen added this pull request to the Graphite merge queue.
• May 1, 9:11 PM EDT: Merged by the Graphite merge queue.