Skip to content

feat(ast_tools): AstBuilder generator support types with more than 1 Atom field#10737

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-30-feat_ast_tools_astbuilder_generator_support_types_with_more_than_1_atom_field
May 1, 2025
Merged

feat(ast_tools): AstBuilder generator support types with more than 1 Atom field#10737
graphite-app[bot] merged 1 commit intomainfrom
04-30-feat_ast_tools_astbuilder_generator_support_types_with_more_than_1_atom_field

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 1, 2025

Previously the code generator for AstBuilder could not handle types with more than 1 field which is an Atom. Currently we don't have any such types, but we might alter the AST in future so that we do. There seems little point in not supporting that.

Copy link
Member Author

overlookmotel commented May 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented May 1, 2025

CodSpeed Instrumentation Performance Report

Merging #10737 will not alter performance

Comparing 04-30-feat_ast_tools_astbuilder_generator_support_types_with_more_than_1_atom_field (60347e7) with 04-30-refactor_ast_astbuilder_methods_require_an_atom_with_correct_lifetime (a0a37e0)

Summary

✅ 36 untouched benchmarks

@graphite-app graphite-app bot force-pushed the 04-30-refactor_ast_astbuilder_methods_require_an_atom_with_correct_lifetime branch from 6d754b2 to 16cf0d2 Compare May 1, 2025 02:12
@graphite-app graphite-app bot requested a review from Dunqing as a code owner May 1, 2025 02:12
@graphite-app graphite-app bot force-pushed the 04-30-feat_ast_tools_astbuilder_generator_support_types_with_more_than_1_atom_field branch from 293133e to 735bdfe Compare May 1, 2025 02:13
@graphite-app graphite-app bot force-pushed the 04-30-refactor_ast_astbuilder_methods_require_an_atom_with_correct_lifetime branch from 16cf0d2 to 6b572f2 Compare May 1, 2025 06:57
@graphite-app graphite-app bot force-pushed the 04-30-feat_ast_tools_astbuilder_generator_support_types_with_more_than_1_atom_field branch from 735bdfe to 2d2b3fa Compare May 1, 2025 06:58
@graphite-app graphite-app bot force-pushed the 04-30-refactor_ast_astbuilder_methods_require_an_atom_with_correct_lifetime branch 2 times, most recently from 2c406a4 to 77694ac Compare May 1, 2025 09:18
@graphite-app graphite-app bot force-pushed the 04-30-feat_ast_tools_astbuilder_generator_support_types_with_more_than_1_atom_field branch from 2d2b3fa to 395fdf9 Compare May 1, 2025 09:18
@overlookmotel overlookmotel force-pushed the 04-30-feat_ast_tools_astbuilder_generator_support_types_with_more_than_1_atom_field branch from 395fdf9 to 77570a3 Compare May 1, 2025 09:39
@overlookmotel overlookmotel force-pushed the 04-30-refactor_ast_astbuilder_methods_require_an_atom_with_correct_lifetime branch from 77694ac to 5c261ad Compare May 1, 2025 12:58
@overlookmotel overlookmotel force-pushed the 04-30-feat_ast_tools_astbuilder_generator_support_types_with_more_than_1_atom_field branch from 77570a3 to db89a97 Compare May 1, 2025 12:58
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 1, 2025
Copy link
Member

Boshen commented May 1, 2025

Merge activity

  • May 1, 9:51 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@graphite-app
Copy link
Contributor

graphite-app bot commented May 1, 2025

Merge activity

…1 `Atom` field (#10737)

Previously the code generator for `AstBuilder` could not handle types with more than 1 field which is an `Atom`. Currently we don't have any such types, but we might alter the AST in future so that we do. There seems little point in not supporting that.
@graphite-app graphite-app bot force-pushed the 04-30-refactor_ast_astbuilder_methods_require_an_atom_with_correct_lifetime branch from 5c261ad to a0a37e0 Compare May 1, 2025 14:29
@graphite-app graphite-app bot force-pushed the 04-30-feat_ast_tools_astbuilder_generator_support_types_with_more_than_1_atom_field branch from db89a97 to 60347e7 Compare May 1, 2025 14:29
Base automatically changed from 04-30-refactor_ast_astbuilder_methods_require_an_atom_with_correct_lifetime to main May 1, 2025 14:39
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 1, 2025
@graphite-app graphite-app bot merged commit 60347e7 into main May 1, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 04-30-feat_ast_tools_astbuilder_generator_support_types_with_more_than_1_atom_field branch May 1, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants