feat(ast_tools): AstBuilder generator support types with more than 1 Atom field#10737
Merged
graphite-app[bot] merged 1 commit intomainfrom May 1, 2025
Conversation
This was referenced May 1, 2025
This was referenced May 1, 2025
Member
Author
This was referenced May 1, 2025
CodSpeed Instrumentation Performance ReportMerging #10737 will not alter performanceComparing Summary
|
6d754b2 to
16cf0d2
Compare
293133e to
735bdfe
Compare
16cf0d2 to
6b572f2
Compare
735bdfe to
2d2b3fa
Compare
2c406a4 to
77694ac
Compare
2d2b3fa to
395fdf9
Compare
395fdf9 to
77570a3
Compare
77694ac to
5c261ad
Compare
77570a3 to
db89a97
Compare
Member
Merge activity
|
Contributor
Merge activity
|
…1 `Atom` field (#10737) Previously the code generator for `AstBuilder` could not handle types with more than 1 field which is an `Atom`. Currently we don't have any such types, but we might alter the AST in future so that we do. There seems little point in not supporting that.
5c261ad to
a0a37e0
Compare
db89a97 to
60347e7
Compare
Base automatically changed from
04-30-refactor_ast_astbuilder_methods_require_an_atom_with_correct_lifetime
to
main
May 1, 2025 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Previously the code generator for
AstBuildercould not handle types with more than 1 field which is anAtom. Currently we don't have any such types, but we might alter the AST in future so that we do. There seems little point in not supporting that.