perf(transformer/regexp): avoid copying string data and temp String#10723
Merged
graphite-app[bot] merged 1 commit intomainfrom May 1, 2025
Conversation
Member
Author
CodSpeed Instrumentation Performance ReportMerging #10723 will not alter performanceComparing Summary
|
7d86281 to
5e58742
Compare
c4ce75e to
c1b758a
Compare
c1b758a to
4285278
Compare
5e58742 to
12d1f44
Compare
This was referenced Apr 30, 2025
acc7c22 to
e96f818
Compare
12d1f44 to
2f226b0
Compare
Contributor
Merge activity
|
…#10723) Avoid temp `String` and copying string data by: 1. Reusing existing `Atom` where possible, instead of copying the string data and creating a new `Atom`. 2. Use `format_atom!` macro (introduced in #10722) to avoid creating a temporary `String` when converting `oxc_regular_expression::Pattern` to a string.
e96f818 to
2256918
Compare
2f226b0 to
8e902a5
Compare
Base automatically changed from
04-30-perf_transformer_jsx_skip_creating_temp_string_
to
main
May 1, 2025 06:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Avoid temp
Stringand copying string data by:Atomwhere possible, instead of copying the string data and creating a newAtom.format_atom!macro (introduced in feat(span): introduceformat_atom!macro #10722) to avoid creating a temporaryStringwhen convertingoxc_regular_expression::Patternto a string.