Skip to content

fix(codegen): add missing in out from ts type parameter#10696

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-29-fix_codegen_add_missing_in_out_from_ts_type_parameter
Apr 29, 2025
Merged

fix(codegen): add missing in out from ts type parameter#10696
graphite-app[bot] merged 1 commit intomainfrom
04-29-fix_codegen_add_missing_in_out_from_ts_type_parameter

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Apr 29, 2025

interface I<in out T> {}
function F<const in out T>() {}

@graphite-app graphite-app bot changed the base branch from 04-29-fix_codegen_add_missing_return_type_from_object_methods to graphite-base/10696 April 29, 2025 12:11
@github-actions github-actions bot added the A-codegen Area - Code Generation label Apr 29, 2025
Copy link
Member Author

Boshen commented Apr 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 29, 2025

CodSpeed Instrumentation Performance Report

Merging #10696 will not alter performance

Comparing 04-29-fix_codegen_add_missing_in_out_from_ts_type_parameter (4825eb5) with main (24ada6f)

Summary

✅ 36 untouched benchmarks

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 29, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 04-29-fix_codegen_add_missing_in_out_from_ts_type_parameter branch from 4e3e9dd to 27566bb Compare April 29, 2025 14:01
@graphite-app graphite-app bot force-pushed the graphite-base/10696 branch from 5240e6f to 06f796f Compare April 29, 2025 14:01
@graphite-app graphite-app bot changed the base branch from graphite-base/10696 to main April 29, 2025 14:02
@graphite-app graphite-app bot force-pushed the 04-29-fix_codegen_add_missing_in_out_from_ts_type_parameter branch from 27566bb to 34b1feb Compare April 29, 2025 14:02
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
```ts
interface I<in out T> {}
function F<const in out T>() {}
```
@graphite-app graphite-app bot force-pushed the 04-29-fix_codegen_add_missing_in_out_from_ts_type_parameter branch from 34b1feb to 4825eb5 Compare April 29, 2025 14:47
@graphite-app graphite-app bot merged commit 4825eb5 into main Apr 29, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 04-29-fix_codegen_add_missing_in_out_from_ts_type_parameter branch April 29, 2025 14:53
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant