Skip to content

fix(codegen): add missing return type from object methods#10694

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-29-fix_codegen_add_missing_return_type_from_object_methods
Apr 29, 2025
Merged

fix(codegen): add missing return type from object methods#10694
graphite-app[bot] merged 1 commit intomainfrom
04-29-fix_codegen_add_missing_return_type_from_object_methods

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Apr 29, 2025

({ foo(): string {} })
          ^^^^^^

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 29, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
@github-actions github-actions bot added A-codegen Area - Code Generation C-bug Category - Bug and removed 0-merge Merge with Graphite Merge Queue labels Apr 29, 2025
@Boshen Boshen added 0-merge Merge with Graphite Merge Queue and removed C-bug Category - Bug A-codegen Area - Code Generation labels Apr 29, 2025
Copy link
Member Author

Boshen commented Apr 29, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 29, 2025

CodSpeed Instrumentation Performance Report

Merging #10694 will not alter performance

Comparing 04-29-fix_codegen_add_missing_return_type_from_object_methods (06f796f) with main (c48f6ae)

Summary

✅ 36 untouched benchmarks

@Boshen Boshen force-pushed the 04-29-fix_codegen_add_missing_return_type_from_object_methods branch from 85c1aae to 73c1d6d Compare April 29, 2025 11:53
@github-actions github-actions bot added A-codegen Area - Code Generation C-bug Category - Bug labels Apr 29, 2025
graphite-app bot pushed a commit that referenced this pull request Apr 29, 2025
@graphite-app graphite-app bot force-pushed the 04-29-fix_codegen_add_missing_return_type_from_object_methods branch from 73c1d6d to 5240e6f Compare April 29, 2025 12:01
Copy link
Member Author

Boshen commented Apr 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

graphite-app bot pushed a commit that referenced this pull request Apr 29, 2025
@graphite-app graphite-app bot force-pushed the 04-29-fix_codegen_add_missing_return_type_from_object_methods branch from 5240e6f to 6f2eadb Compare April 29, 2025 12:11
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
@graphite-app graphite-app bot force-pushed the 04-29-fix_codegen_add_missing_return_type_from_object_methods branch from 6f2eadb to 06f796f Compare April 29, 2025 13:54
@graphite-app graphite-app bot merged commit 06f796f into main Apr 29, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 04-29-fix_codegen_add_missing_return_type_from_object_methods branch April 29, 2025 14:01
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant