test(editor): add tests for multi workspace folder setup#10648
Closed
Sysix wants to merge 1 commit into04-20-feat_language_server_support_multiple_workspacesfrom
Closed
Conversation
github-actions
bot
added
A-editor
This was referenced Apr 27, 2025
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sysix
force-pushed
the
04-27-test_editor_add_tests_for_multi_root_workspaces
branch
from
44d4214 to
1bb9544
Compare
Sysix
force-pushed
the
04-20-feat_language_server_support_multiple_workspaces
branch
from
49202a7 to
0022bcc
Compare
Sysix
force-pushed
the
04-27-test_editor_add_tests_for_multi_root_workspaces
branch
from
1bb9544 to
2f30901
Compare
Sysix
force-pushed
the
04-20-feat_language_server_support_multiple_workspaces
branch
from
0022bcc to
cae8ea5
Compare
Sysix
force-pushed
the
04-27-test_editor_add_tests_for_multi_root_workspaces
branch
2 times, most recently
from
6a8687d to
bfbffad
Compare
Sysix
force-pushed
the
04-20-feat_language_server_support_multiple_workspaces
branch
from
cae8ea5 to
e52464a
Compare
Sysix
force-pushed
the
04-27-test_editor_add_tests_for_multi_root_workspaces
branch
from
bfbffad to
8822bad
Compare
Sysix
force-pushed
the
04-20-feat_language_server_support_multiple_workspaces
branch
from
e52464a to
cfd7918
Compare
Sysix
force-pushed
the
04-27-test_editor_add_tests_for_multi_root_workspaces
branch
from
8822bad to
09224f8
Compare
Sysix
force-pushed
the
04-20-feat_language_server_support_multiple_workspaces
branch
from
cfd7918 to
f6c1f06
Compare
Sysix
force-pushed
the
04-27-test_editor_add_tests_for_multi_root_workspaces
branch
from
09224f8 to
a7fd187
Compare
Sysix
changed the title
Sysix
changed the title
Sysix
force-pushed
the
04-27-test_editor_add_tests_for_multi_root_workspaces
branch
from
a7fd187 to
ed96883
Compare
Sysix
force-pushed
the
04-20-feat_language_server_support_multiple_workspaces
branch
from
f6c1f06 to
05ed2c1
Compare
Sysix
force-pushed
the
04-27-test_editor_add_tests_for_multi_root_workspaces
branch
from
ed96883 to
53dd21f
Compare
Sysix
force-pushed
the
04-20-feat_language_server_support_multiple_workspaces
branch
2 times, most recently
from
6c24b23 to
74d4a12
Compare
Sysix
force-pushed
the
04-27-test_editor_add_tests_for_multi_root_workspaces
branch
from
53dd21f to
7153809
Compare
Sysix
force-pushed
the
04-20-feat_language_server_support_multiple_workspaces
branch
from
74d4a12 to
08c162b
Compare
Sysix
force-pushed
the
04-27-test_editor_add_tests_for_multi_root_workspaces
branch
from
7153809 to
0302675
Compare
Sysix
force-pushed
the
04-27-test_editor_add_tests_for_multi_root_workspaces
branch
from
0302675 to
228d797
Compare
Sysix
changed the base branch from
04-20-feat_language_server_support_multiple_workspaces
to
graphite-base/10648
Sysix
force-pushed
the
graphite-base/10648
branch
from
08c162b to
01cc2e4
Compare
Sysix
force-pushed
the
04-27-test_editor_add_tests_for_multi_root_workspaces
branch
from
228d797 to
a68d729
Compare
Sysix
changed the base branch from
graphite-base/10648
to
04-20-feat_language_server_support_multiple_workspaces
Sysix
force-pushed
the
04-27-test_editor_add_tests_for_multi_root_workspaces
branch
6 times, most recently
from
af00107 to
eb22bd5
Compare
Sysix
commented
Apr 30, 2025
| strictEqual(secondDiagnostics[0].severity, DiagnosticSeverity.Error); | ||
| }) | ||
|
|
||
| test('cross module', async () => { |
Member
Author
There was a problem hiding this comment.
I needed to move the test to the end to work. I do not have an idea why, and it is already frustrating enough to create tests for vscode^^
Sysix
commented
Apr 30, 2025
| strictEqual(folderDiagnostics[0].code.target.authority, 'oxc.rs'); | ||
| strictEqual(folderDiagnostics[0].severity, DiagnosticSeverity.Warning); | ||
|
|
||
| workspace.updateWorkspaceFolders(workspace.workspaceFolders?.length ?? 0, 0, { |
Member
Author
There was a problem hiding this comment.
Adding folders only works when we have already a multi folder setup.
Adding a folder in single folder setup will restart the VSCode Window and makes some weird tests bugs
Sysix
force-pushed
the
04-27-test_editor_add_tests_for_multi_root_workspaces
branch
from
eb22bd5 to
cde9ae1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have now 3 different test setups:
test()Will be executed in both modes. Should be used to make sure this works for both ways.
testSingleFolderMode()Will only be executed for single folders. Testing with multi folder is redundant.
testMultiFolderMode()Will only be executed in multi folder mode. These are special tests which are only designed for multi folders and makes no sense that it will work in single folder.