refactor(language_server): do not request for worspace configuration when the client does not support it#10507
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 21, 2025
Conversation
This was referenced Apr 19, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10507 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
ebafe04 to
246d6dc
Compare
0fb50ec to
1fa3178
Compare
camchenry
approved these changes
Apr 21, 2025
Member
Author
Merge activity
|
…when the client does not support it (#10507) Currently working on supporting multiple workspace folder. `workspace/didChangeConfiguratoin` does not specific the Workspace, so some clients expect to request them. We need to check if the client support this or fallback to a global configuration change (changing all workspaces). ChatGPT: > what if workspace/configuration is not supported by the clinet ChatGPT: Ah, good follow-up — if the client does not support workspace/configuration, things get more limited and require some careful handling. 🔧 First: Check If the Client Supports It When your language server receives the initialize request from the client, it includes its capabilities. Look for: ``` "capabilities": { "workspace": { "configuration": true } } ``` > If that configuration field is false or missing, then you cannot use workspace/configuration, and the client will only send global settings via workspace/didChangeConfiguration.
1fa3178 to
9f9e0e5
Compare
246d6dc to
db05a15
Compare
Base automatically changed from
04-17-refactor_language_server_move_code_actions_into_own_file
to
main
April 21, 2025 18:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Currently working on supporting multiple workspace folder.
workspace/didChangeConfiguratoindoes not specific the Workspace, so some clients expect to request them.We need to check if the client support this or fallback to a global configuration change (changing all workspaces).
ChatGPT: