Skip to content

perf(parser): fast path for parsing ts declarations #10596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 24, 2025
Merged

perf(parser): fast path for parsing ts declarations #10596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion crates/oxc_parser/src/js/statement.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,25 @@ impl<'a> ParserImpl<'a> {
{
self.parse_using_statement()
}
_ if self.is_ts && self.at_start_of_ts_declaration() => {
Kind::Async
| Kind::Interface
| Kind::Type
| Kind::Module
| Kind::Namespace
| Kind::Declare
| Kind::Const
| Kind::Enum
| Kind::Import
| Kind::Private
| Kind::Protected
| Kind::Public
| Kind::Abstract
| Kind::Accessor
| Kind::Static
| Kind::Readonly
| Kind::Global
if self.is_ts && self.at_start_of_ts_declaration() =>
{
self.parse_ts_declaration_statement(start_span)
}
_ => self.parse_expression_or_labeled_statement(),
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_parser/src/ts/statement.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ impl<'a> ParserImpl<'a> {
self.lookahead(Self::at_start_of_ts_declaration_worker)
}

/// Check if the parser is at a start of a declaration
/// Check if the parser is at a start of a ts declaration
fn at_start_of_ts_declaration_worker(&mut self) -> bool {
loop {
match self.cur_kind() {
Expand Down
Loading