Skip to content

perf(parser): fast path for parsing ts declarations#10596

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-24-perf_parser_fast_path_for_parsing_ts_declarations
Apr 24, 2025
Merged

perf(parser): fast path for parsing ts declarations#10596
graphite-app[bot] merged 1 commit intomainfrom
04-24-perf_parser_fast_path_for_parsing_ts_declarations

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Apr 24, 2025

closes #10593

@github-actions github-actions bot added A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance labels Apr 24, 2025
Copy link
Member Author

Boshen commented Apr 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 24, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 24, 2025

CodSpeed Instrumentation Performance Report

Merging #10596 will not alter performance

Comparing 04-24-perf_parser_fast_path_for_parsing_ts_declarations (3fafc0d) with main (4f56b2c)

Summary

✅ 36 untouched benchmarks

@graphite-app graphite-app bot force-pushed the 04-24-perf_parser_fast_path_for_parsing_ts_declarations branch from ad3f849 to 3fafc0d Compare April 24, 2025 14:52
@graphite-app graphite-app bot merged commit 3fafc0d into main Apr 24, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 04-24-perf_parser_fast_path_for_parsing_ts_declarations branch April 24, 2025 14:58
@Boshen
Copy link
Member Author

Boshen commented Apr 24, 2025

Tiny 1% improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf(parser): slow rountine on at_start_of_ts_declaration

1 participant