Skip to content

feat(transformer/typescript): support allowDeclareFields: false for backward compatibility#10585

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-24-feat_transformer_typescript_support_for_backward_compatibility
Apr 25, 2025
Merged

feat(transformer/typescript): support allowDeclareFields: false for backward compatibility#10585
graphite-app[bot] merged 1 commit intomainfrom
04-24-feat_transformer_typescript_support_for_backward_compatibility

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 24, 2025

Although allow_declare_fields is deprecated, we still need to support it for backward compatibility.

Copy link
Member Author

Dunqing commented Apr 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Apr 24, 2025
@Dunqing Dunqing marked this pull request as ready for review April 24, 2025 08:25
@Dunqing Dunqing requested a review from overlookmotel as a code owner April 24, 2025 08:25
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 24, 2025

CodSpeed Instrumentation Performance Report

Merging #10585 will not alter performance

Comparing 04-24-feat_transformer_typescript_support_for_backward_compatibility (fae8c26) with 04-24-feat_transformer_napi_transform_deprecate_allowdeclarefields_option (42ca96a)

Summary

✅ 36 untouched benchmarks

@Dunqing Dunqing force-pushed the 04-24-feat_transformer_typescript_support_for_backward_compatibility branch from 7a7ea8c to b87481b Compare April 24, 2025 08:30
@Dunqing Dunqing force-pushed the 04-24-feat_transformer_napi_transform_deprecate_allowdeclarefields_option branch from fbf48d4 to b087a5a Compare April 24, 2025 08:30
@Dunqing Dunqing force-pushed the 04-24-feat_transformer_typescript_support_for_backward_compatibility branch from b87481b to 4018cdc Compare April 24, 2025 09:56
@Dunqing Dunqing force-pushed the 04-24-feat_transformer_napi_transform_deprecate_allowdeclarefields_option branch from b087a5a to c7f3c06 Compare April 24, 2025 09:56
@Dunqing Dunqing requested a review from sapphi-red April 24, 2025 09:57
@Dunqing Dunqing force-pushed the 04-24-feat_transformer_typescript_support_for_backward_compatibility branch from 4018cdc to dec8360 Compare April 24, 2025 14:09
@Dunqing Dunqing force-pushed the 04-24-feat_transformer_napi_transform_deprecate_allowdeclarefields_option branch from c7f3c06 to 85c0a39 Compare April 24, 2025 14:09
@Dunqing
Copy link
Member Author

Dunqing commented Apr 25, 2025

@sapphi-red Thank you for reviewing the whole stack!

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Apr 25, 2025
Copy link
Member Author

Dunqing commented Apr 25, 2025

Merge activity

… backward compatibility (#10585)

Although `allow_declare_fields` is deprecated, we still need to support it for backward compatibility.
@graphite-app graphite-app bot force-pushed the 04-24-feat_transformer_napi_transform_deprecate_allowdeclarefields_option branch from 85c0a39 to 42ca96a Compare April 25, 2025 01:32
@graphite-app graphite-app bot force-pushed the 04-24-feat_transformer_typescript_support_for_backward_compatibility branch from dec8360 to fae8c26 Compare April 25, 2025 01:32
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 25, 2025
@sapphi-red
Copy link
Member

Thanks for implementing!

Base automatically changed from 04-24-feat_transformer_napi_transform_deprecate_allowdeclarefields_option to main April 25, 2025 01:47
@graphite-app graphite-app bot merged commit fae8c26 into main Apr 25, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-24-feat_transformer_typescript_support_for_backward_compatibility branch April 25, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants