feat(transformer/typescript): support removeClassFieldsWithoutInitializer option#10576
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 25, 2025
Conversation
github-actions
bot
added
A-transformer
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10576 will not alter performanceComparing Summary
Benchmarks breakdown
|
Dunqing
force-pushed
the
04-24-feat_transformer_typescript_support_removeclassfieldswithoutinitializer_option
branch
from
32a213f to
23c0ece
Compare
Member
Author
|
@sapphi-red could you review this? |
sapphi-red
reviewed
Apr 24, 2025
This was referenced Apr 24, 2025
Dunqing
force-pushed
the
04-24-feat_transformer_typescript_support_removeclassfieldswithoutinitializer_option
branch
from
23c0ece to
097d8d4
Compare
sapphi-red
approved these changes
Apr 24, 2025
Contributor
Merge activity
|
…lizer` option (#10576) * close #9192 * close #10491 We've discussed adding `removeClassFieldsWithoutInitializer` option to support removing class fields without an initializer in #10491 (comment). This is used to align the`TypeScript`'s `useDefineForClassFields: false` option.
graphite-app
bot
force-pushed
the
04-24-feat_transformer_typescript_support_removeclassfieldswithoutinitializer_option
branch
from
097d8d4 to
6bff64e
Compare
graphite-app
bot
deleted the
04-24-feat_transformer_typescript_support_removeclassfieldswithoutinitializer_option
branch
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assumptions.setPublicClassFieldsdoesn't fully simulate tsconfiguseDefineForClassFields#9192setPublicClassFieldswith TypeScript'suseDefineForClassFields: false#10491We've discussed adding
removeClassFieldsWithoutInitializeroption to support removing class fields without an initializer in #10491 (comment). This is used to align theTypeScript'suseDefineForClassFields: falseoption.