Skip to content

perf(napi/parser): lazy load raw transfer deserializers #10482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 29, 2025
Merged

perf(napi/parser): lazy load raw transfer deserializers #10482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions napi/parser/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
const bindings = require('./bindings.js');
const deserializeJS = require('./generated/deserialize/js.js');
const deserializeTS = require('./generated/deserialize/ts.js');
const { wrap } = require('./wrap.cjs');

module.exports.ParseResult = bindings.ParseResult;
Expand All @@ -22,7 +20,7 @@ module.exports.parseSync = function parseSync(filename, sourceText, options) {
return wrap(bindings.parseSync(filename, sourceText, options));
};

let buffer, encoder;
let buffer, encoder, deserializeJS, deserializeTS;

function parseSyncRaw(filename, sourceText, options) {
if (!rawTransferSupported()) {
Expand Down Expand Up @@ -62,14 +60,17 @@ function parseSyncRaw(filename, sourceText, options) {
const astTypeFlagPos = 2147483636;
let isJsAst = buffer[astTypeFlagPos] === 0;

// Lazy load deserializer, and deserialize buffer to JS objects
let data;
if (isJsAst) {
if (!deserializeJS) deserializeJS = require('./generated/deserialize/js.js');
data = deserializeJS(buffer, sourceText, sourceByteLen);
const { hashbang } = data.program;
if (hashbang !== null) {
data.comments.unshift({ type: 'Line', value: hashbang.value, start: hashbang.start, end: hashbang.end });
}
} else {
if (!deserializeTS) deserializeTS = require('./generated/deserialize/ts.js');
data = deserializeTS(buffer, sourceText, sourceByteLen);
}

Expand Down
Loading