perf(napi/parser): lazy load raw transfer deserializers#10482
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 29, 2025
Merged
Conversation
github-actions
bot
added
the
C-performance
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Merge activity
|
graphite-app
bot
force-pushed
the
04-17-refactor_napi_parser_move_generated_deserializer_files
branch
from
bdab229 to
5a4367e
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 19, 2025
Don't eagerly load raw transfer deserializer code. These files are large and will take JS engine some time to parse. Instead, `require` the appropriate deserializer lazily, when it's first needed. For the majority of users who aren't using raw transfer (almost everyone, as it's currently behind an experimental option), avoid loading this code entirely.
graphite-app
bot
force-pushed
the
04-17-perf_napi_parser_lazy_load_raw_transfer_deserializers
branch
from
7f8d29e to
bf791b7
Compare
overlookmotel
added a commit
that referenced
this pull request
Apr 22, 2025
Don't eagerly load raw transfer deserializer code. These files are large and will take JS engine some time to parse. Instead, `require` the appropriate deserializer lazily, when it's first needed. For the majority of users who aren't using raw transfer (almost everyone, as it's currently behind an experimental option), avoid loading this code entirely.
overlookmotel
force-pushed
the
04-17-perf_napi_parser_lazy_load_raw_transfer_deserializers
branch
from
bf791b7 to
ff88a4b
Compare
Don't eagerly load raw transfer deserializer code. These files are large and will take JS engine some time to parse. Instead, `require` the appropriate deserializer lazily, when it's first needed. For the majority of users who aren't using raw transfer (almost everyone, as it's currently behind an experimental option), avoid loading this code entirely.
overlookmotel
force-pushed
the
04-17-perf_napi_parser_lazy_load_raw_transfer_deserializers
branch
from
ff88a4b to
d882eaa
Compare
overlookmotel
force-pushed
the
04-17-refactor_napi_parser_move_generated_deserializer_files
branch
from
0368a3a to
3b6d52d
Compare
Base automatically changed from
04-17-refactor_napi_parser_move_generated_deserializer_files
to
main
April 29, 2025 09:54
graphite-app
bot
deleted the
04-17-perf_napi_parser_lazy_load_raw_transfer_deserializers
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't eagerly load raw transfer deserializer code. These files are large and will take JS engine some time to parse. Instead,
requirethe appropriate deserializer lazily, when it's first needed.For the majority of users who aren't using raw transfer (almost everyone, as it's currently behind an experimental option), avoid loading this code entirely.