Skip to content

perf(linter): replace phf_set with array in jsx-a11y/no-noninteractive-tabindex #10306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 7, 2025
Merged

perf(linter): replace phf_set with array in jsx-a11y/no-noninteractive-tabindex #10306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 27 additions & 9 deletions crates/oxc_linter/src/rules/jsx_a11y/no_noninteractive_tabindex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use oxc_ast::{
use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint;
use oxc_span::{CompactStr, Span};
use phf::phf_set;

use crate::{
AstNode,
Expand Down Expand Up @@ -82,15 +81,34 @@ declare_oxc_lint!(
);

// https://html.spec.whatwg.org/multipage/dom.html#interactive-content
const INTERACTIVE_HTML_ELEMENTS: phf::set::Set<&'static str> = phf_set! {
"a", "audio", "button", "details", "embed", "iframe", "img", "input", "label", "select", "textarea", "video"
};
const INTERACTIVE_HTML_ELEMENTS: [&str; 12] = [
"a", "audio", "button", "details", "embed", "iframe", "img", "input", "label", "select",
"textarea", "video",
];

// https://www.w3.org/TR/wai-aria/#widget_roles
// NOTE: "tabpanel" is not included here because it's technically a section role. It can optionally be considered interactive within the context of a tablist, because its visibility is dynamically controlled by an element with the "tab" aria role. It's included in the recommended jsx-a11y config for this reason.
const INTERACTIVE_HTML_ROLES: phf::set::Set<&'static str> = phf_set! {
"button", "checkbox", "gridcell", "link", "menuitem", "menuitemcheckbox", "menuitemradio", "option", "progressbar", "radio", "scrollbar", "searchbox", "separator", "slider", "spinbutton", "switch", "tab", "textbox", "treeitem"
};
const INTERACTIVE_HTML_ROLES: [&str; 19] = [
"button",
"checkbox",
"gridcell",
"link",
"menuitem",
"menuitemcheckbox",
"menuitemradio",
"option",
"progressbar",
"radio",
"scrollbar",
"searchbox",
"separator",
"slider",
"spinbutton",
"switch",
"tab",
"textbox",
"treeitem",
];

impl Rule for NoNoninteractiveTabindex {
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
Expand All @@ -114,7 +132,7 @@ impl Rule for NoNoninteractiveTabindex {

let component = &get_element_type(ctx, jsx_el);

if INTERACTIVE_HTML_ELEMENTS.contains(component) {
if INTERACTIVE_HTML_ELEMENTS.contains(&component.as_ref()) {
return;
}

Expand All @@ -134,7 +152,7 @@ impl Rule for NoNoninteractiveTabindex {
return;
};

if !INTERACTIVE_HTML_ROLES.contains(role.value.as_str())
if !INTERACTIVE_HTML_ROLES.contains(&role.value.as_str())
&& !self.0.roles.contains(&CompactStr::new(role.value.as_str()))
{
ctx.diagnostic(no_noninteractive_tabindex_diagnostic(tabindex_attr.span));
Expand Down
Loading