Skip to content

perf(linter): replace phf_set with array in jsx-a11y/no-noninteractive-tabindex#10306

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-08-perf/replace-phf_set-with-array-in-jsx-a11y/no-noninteractive-tabindex
Apr 7, 2025
Merged

perf(linter): replace phf_set with array in jsx-a11y/no-noninteractive-tabindex#10306
graphite-app[bot] merged 1 commit intomainfrom
04-08-perf/replace-phf_set-with-array-in-jsx-a11y/no-noninteractive-tabindex

Conversation

@shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Apr 7, 2025

Related to #10076

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Apr 7, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 7, 2025

CodSpeed Instrumentation Performance Report

Merging #10306 will degrade performances by 3.54%

Comparing 04-08-perf/replace-phf_set-with-array-in-jsx-a11y/no-noninteractive-tabindex (d7399c4) with main (876b6ea)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.6 ms 7.9 ms -3.54%
formatter[typescript.js] 7.6 ms 7.2 ms +5.37%

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 7, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 04-08-perf/replace-phf_set-with-array-in-jsx-a11y/no-noninteractive-tabindex branch from 27f3e6f to d7399c4 Compare April 7, 2025 19:44
@graphite-app graphite-app bot merged commit d7399c4 into main Apr 7, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 04-08-perf/replace-phf_set-with-array-in-jsx-a11y/no-noninteractive-tabindex branch April 7, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant