Skip to content

refactor(ast/estree): simplify static converters#10197

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-03-refactor_ast_estree_simplify_simple_converters
Apr 3, 2025
Merged

refactor(ast/estree): simplify static converters#10197
graphite-app[bot] merged 1 commit intomainfrom
04-03-refactor_ast_estree_simplify_simple_converters

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Apr 3, 2025

Pure refactor. Simplify the converters which produce static values e.g. null. They can contain a T rather than a &T - T is generic, so can be a & itself.

#10192 made me realize this was more complex than it needed to be.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 3, 2025
@overlookmotel overlookmotel marked this pull request as ready for review April 3, 2025 10:37
@overlookmotel
Copy link
Member Author

No change to serialized output, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 3, 2025
Copy link
Member Author

overlookmotel commented Apr 3, 2025

Merge activity

@overlookmotel overlookmotel changed the title refactor(ast/estree): simplify simple converters refactor(ast/estree): simplify static converters Apr 3, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 3, 2025

CodSpeed Instrumentation Performance Report

Merging #10197 will degrade performances by 3.42%

Comparing 04-03-refactor_ast_estree_simplify_simple_converters (5525206) with main (db0b2eb)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.9 ms 7.6 ms +3.88%
formatter[typescript.js] 7.2 ms 7.4 ms -3.42%

Pure refactor. Simplify the converters which produce static values e.g. `null`. They can contain a `T` rather than a `&T` - `T` is generic, so can be a `&` itself.

#10192 made me realize this was more complex than it needed to be.
@graphite-app graphite-app bot force-pushed the 04-03-refactor_ast_estree_simplify_simple_converters branch from b83eb82 to 5525206 Compare April 3, 2025 10:47
@graphite-app graphite-app bot merged commit 5525206 into main Apr 3, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 04-03-refactor_ast_estree_simplify_simple_converters branch April 3, 2025 10:56
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant