fix(ast/estree): Add ts-estree fields to FormalParametersRest custom serializer#10192
Merged
overlookmotel merged 4 commits intooxc-project:mainfrom Apr 3, 2025
Merged
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
therewillbecode
commented
Apr 2, 2025
CodSpeed Instrumentation Performance ReportMerging #10192 will not alter performanceComparing Summary
|
therewillbecode
force-pushed
the
fix/formal-parameters-rest
branch
3 times, most recently
from
d57a041 to
031221c
Compare
overlookmotel
force-pushed
the
fix/formal-parameters-rest
branch
from
031221c to
6374f55
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 3, 2025
Pure refactor. Simplify the converters which produce static values e.g. `null`. They can contain a `T` rather than a `&T` - `T` is generic, so can be a `&` itself. #10192 made me realize this was more complex than it needed to be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
decoratorsandvaluefields to theFormalParametersRestcustom TS-EStree serializer.Part of our broader work to align our AST's ESTree output with that of TS-ESLint's. Relates to #9705