fix(parser): store lone surrogates in TemplateElementValue as escape sequence#10182
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 2, 2025
Conversation
This was referenced Apr 2, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10182 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
2c70b2c to
3bca1f2
Compare
Contributor
Merge activity
|
…e sequence (#10182) Encode lone surrogates in `cooked` property of `TemplateElementValue` using same encoding scheme as for `StringLiteral`s. In fact, they were already being encoded like this after #10041, but add a `lone_surrogates` flag to `TemplateLiteral` to decode them correctly in ESTree AST. `oxc_codegen` ignores `cooked` and just prints `raw`, so needs no alteration.
74ec89a to
38d2bea
Compare
3bca1f2 to
27768a5
Compare
Base automatically changed from
04-02-fix_parser_fix_parsing_lone_surrogates_in_stringliteral_s
to
main
April 2, 2025 13:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Encode lone surrogates in
cookedproperty ofTemplateElementValueusing same encoding scheme as forStringLiterals.In fact, they were already being encoded like this after #10041, but add a
lone_surrogatesflag toTemplateLiteralto decode them correctly in ESTree AST.oxc_codegenignorescookedand just printsraw, so needs no alteration.