Skip to content

test(parser): tests for lone surrogates and lossy escape characters#10175

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-02-test_parser_tests_for_lone_surrogates_and_lossy_escape_characters
Apr 2, 2025
Merged

test(parser): tests for lone surrogates and lossy escape characters#10175
graphite-app[bot] merged 1 commit intomainfrom
04-02-test_parser_tests_for_lone_surrogates_and_lossy_escape_characters

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Apr 2, 2025

Add tests for correct parsing of StringLiterals containing lone surrogates and lossy replacement characters, after #10041.

The tests are in oxc_codegen but primarily these tests test the logic in parser.

Copy link
Member Author

overlookmotel commented Apr 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-codegen Area - Code Generation C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Apr 2, 2025
@overlookmotel overlookmotel marked this pull request as ready for review April 2, 2025 06:52
@overlookmotel overlookmotel requested a review from Boshen April 2, 2025 06:52
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 2, 2025

CodSpeed Instrumentation Performance Report

Merging #10175 will degrade performances by 3.31%

Comparing 04-02-test_parser_tests_for_lone_surrogates_and_lossy_escape_characters (7672620) with main (34d5c00)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.9 ms 7.6 ms +3.88%
formatter[typescript.js] 7.2 ms 7.4 ms -3.31%

@overlookmotel overlookmotel marked this pull request as draft April 2, 2025 08:04
@overlookmotel overlookmotel marked this pull request as ready for review April 2, 2025 08:13
@overlookmotel overlookmotel force-pushed the 04-02-test_parser_tests_for_lone_surrogates_and_lossy_escape_characters branch from daee98a to 2f58955 Compare April 2, 2025 10:50
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 2, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 2, 2025

Merge activity

…10175)

Add tests for correct parsing of `StringLiteral`s containing lone surrogates and lossy replacement characters, after #10041.

The tests are in `oxc_codegen` but primarily these tests test the logic in parser.
@graphite-app graphite-app bot force-pushed the 04-02-test_parser_tests_for_lone_surrogates_and_lossy_escape_characters branch from 2f58955 to 7672620 Compare April 2, 2025 12:57
@graphite-app graphite-app bot merged commit 7672620 into main Apr 2, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-02-test_parser_tests_for_lone_surrogates_and_lossy_escape_characters branch April 2, 2025 13:03
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant